Room link gets lost after OIDC login

[MiroTalk]

@imc67 said in Room link gets lost after OIDC login:

When you receive a direct link to a room, click that, get redirected via OIDC to login, then .... you are redirected to the main page and NOT the original room link.

Guests will be redirected to the OIDC login page until the presenter (authenticated user) joins the room. Please note that the waiting room feature is currently supported only in HOST_PROTECTION mode. For more details, @James check out this issue.

[james]

Hello @mirotalk-57bab571
Thanks for that!
Question, if we find issues or questions here regarding anything related to MiroTalk, is the forum mention OK for you or would you like a ticket on GitHub for better tracking?
And again, a huge thanks for your active participation in our forum.

[MiroTalk]

@james said in Room link gets lost after OIDC login:

Thanks for that!
Question, if we find issues or questions here regarding anything related to MiroTalk, is the forum mention OK for you or would you like a ticket on GitHub for better tracking?
And again, a huge thanks for your active participation in our forum.

You're very welcome!

Posting in the forum is absolutely OK — I follow discussions there as well and often reply, implement new features, or push fixes directly based on what’s shared. So feel free to continue using it for anything related to MiroTalk.

By the way, OIDC + WhoAreYou integration is a work in progress and will be part of the upcoming release (v 1.8.81) — stay tuned!

Thanks again for your great support and feedback

[MiroTalk]

@imc67 said in Room link gets lost after OIDC login:

Can this be solved?

OIDC support for WhoAreYou (waiting room) is now available in MiroTalk SFU v1.8.81!

Docker image build is in progress…

[imc67]

@MiroTalk said in Room link gets lost after OIDC login:

OIDC support for WhoAreYou (waiting room) is now available in MiroTalk SFU v1.8.81!

@mirotalk-57bab571 indeed 1.8.81 solved the issue!! Many many thanks for that!

Just one more thing: can you make the (button)texts on the WhoAreYou page configurable via .env just like the main page?

[MiroTalk]

@imc67 said in Room link gets lost after OIDC login:

@mirotalk-57bab571 indeed 1.8.81 solved the issue!! Many many thanks for that!

Good! You're welcome.

Just one more thing: can you make the (button)texts on the WhoAreYou page configurable via .env just like the main page?

Sure, I like the idea, it will be available in the next release!

You’ll then be able to configure WhoAreYou as needed with the following options in the env:

# Who Are You
WHO_ARE_YOU_TITLE="Who are you?"                  # Title
WHO_ARE_YOU_DESCRIPTION="If you're the presenter, please log in now.<br />Otherwise, kindly wait for the presenter to join." # Description
WHO_ARE_YOU_BUTTON_LOGIN_LABEL="LOGIN"            # Login button label
WHO_ARE_YOU_JOIN_LABEL="JOIN ROOM"                # Join button label

[imc67]

@MiroTalk said in Room link gets lost after OIDC login:

@imc67 said in Room link gets lost after OIDC login:

@mirotalk-57bab571 indeed 1.8.81 solved the issue!! Many many thanks for that!

Good! You're welcome.

Just one more thing: can you make the (button)texts on the WhoAreYou page configurable via .env just like the main page?

Sure, I like the idea, it will be available in the next release!

You’ll then be able to configure WhoAreYou as needed with the following options in the env:

# Who Are You
WHO_ARE_YOU_TITLE="Who are you?"                  # Title
WHO_ARE_YOU_DESCRIPTION="If you're the presenter, please log in now.<br />Otherwise, kindly wait for the presenter to join." # Description
WHO_ARE_YOU_BUTTON_LOGIN_LABEL="LOGIN"            # Login button label
WHO_ARE_YOU_JOIN_LABEL="JOIN ROOM"                # Join button label

This is ABSOLUTELY amazing, again thank you very much!!!

[MiroTalk]

Done in MiroTalk SFU v1.8.84

[nebulon]

package for this release is out now

[nostrdev]

It would be really nice if you can also update the upstream version when bumping packages - it's displayed in the app store, and is a nice visual indicator (if unreliable)

https://git.cloudron.io/packages/mirotalksfu-app/-/blob/main/CloudronManifest.json?ref_type=heads#L5