App list doesn't work, but app grid does (v9.2.0)

[ekevu123]

I am having an issue with Cloudron version 9.2.0. In the app overview, the app list appears empty, but the app grid works.
Can this browser console error be related?

TypeError: can't access property "email", app.manifest.addons is undefined

It would be odd, though, that this crashes only the app list, but not the grid.

[james]

Hello @ekevu123
Do you have some custom app installed?
This hints towards some app with a strange or bad manifest.

[ekevu123]

Yes, I have a few of them. But I think the right behaviour should be that Cloudron flags that in the UI, perhaps even with an icon, so I'll know which app that concerns. And I still find it odd that the grid works, but the list doesn't.

[james]

Hello @ekevu123
That is indeed interesting.
Can you give us the manifest of the app in question so we might reproduce this issue?

[ekevu123]

I figured it out now, see below.

At apptask.js:693, updateCommand calls omit() on the old manifest's addons field without guarding against it being absent. When the installed manifest has no addons
key, addons is undefined, causing Object.entries(undefined) to throw:

TypeError: Cannot convert undefined or null to object
at Object.entries (<anonymous>)
at Object.omit (file:///home/yellowtent/box/src/underscore.js:17:38)
at updateCommand (file:///home/yellowtent/box/src/apptask.js:693:28)

Because this is a plain TypeError rather than a BoxError, the catch block in run passes it to makeTaskError, which asserts error instanceof BoxError and crashes —
surfacing a secondary assertion error to the user instead of the real one.

To reproduce:

1. Install an app whose CloudronManifest.json has no addons field
2. Add "addons": {} to the manifest and push a new image
3. Trigger an update from the dashboard

Expected: Update succeeds, or fails with a descriptive error about the manifest change.
Actual: Task crashes immediately with AssertionError: assert(error instanceof BoxError), hiding the real cause.

I re-installed the app, which solved the issue. I still believe the views should be consistent in error handling though.