Failure installing "additionals" plugin due to RO filesystem

[iets247]

Hi,

I've tried to install the "additionals" plugin for Redmine on the latest available Cloudron Redmine version using the following commands in app/code:

git clone -b main https://github.com/AlphaNodes/additionals.git plugins/additionals
bundle config set --local without 'development test'
bundle install
bundle exec rake redmine:plugins:migrate RAILS_ENV=production

However, the rake fails with:
rake aborted!
Could not create directory /app/code/public/images/emojis: Read-only file system @ dir_s_mkdir - /app/code/public/images/emojis
...
Caused by:
Errno::EROFS: Read-only file system @ dir_s_mkdir - /app/code/public/images/emojis
/app/code/plugins/additionals/lib/additionals/gemify.rb:15:in `install_emoji_assets'

Looking at the listing of app/code suggests that ./public OR at least ./public/images should be symbolic linked to the equivalent writeable item in app/data much like app/code/plugins and app/code/public/plugin_assets

At minimum, please consider exposing ./public/images through app/data/public/images.

Preferably please consider exposing ./public through app/data/public for more flexibility - it's understood that modifications made to these files directly may be overwritten/negated by an update, but at least the modifications could be re-applied as necessary and added files would remain unaffected across updates?

Kindly advise the way forward...

Thanks in advance!

[girish]

@iets247 I have to try this out myself but have you see https://docs.cloudron.io/apps/redmine/#installing-plugins already ? You have to extract the plugin into /app/data/plugins

[iets247]

@girish yes, I read those instructions...executing
git clone -b main https://github.com/AlphaNodes/additionals.git plugins/additionals

from app/code or app/data effectively does the same "extract" the plugin into /app/data/plugins/additionals

except the new folder "additionals" and its sub-folders and files are owned by root:root
I executed chown -hR cloudron:cloudron ./additionals to match with existing folders/files in /app/data/plugins

The rake fails as follows due to /app/code/public/images being read-only:

Could not create directory /app/code/public/images/emojis: Read-only file system @ dir_s_mkdir - /app/code/public/images/emojis

Thanks for looking into this...

[girish]

@iets247 I think this is a bug in the plugin. I have reported it upstream - https://github.com/AlphaNodes/additionals/issues/138

[iets247]

@girish thanks, while pending on upstream investigation of the plugin, what's the feasibility to change /public to be a symbolic link from /app/data so it is by default no longer read-only or at least as an interim "workaround"?

[girish]

@iets247 We can't symlink because it will cause issues when we provide updates. The files in public are readonly because those files come from upstream and they will change in upcoming releases.

Note that the plugin files are very much editable. So, as a hack, can you try disabling this line of code in the plugin https://github.com/AlphaNodes/additionals/blob/55312e4fa591d1f6efb0f1cf1705c0200fbc4f70/lib/additionals.rb#L174 ? Basically:

      # Additionals::Gemify.install_emoji_assets

I don't know what is the effect of not having emoji assets though.

[iets247]

@girish noted and understood, thank you.

[girish]

@iets247 The author has made a fix upstream.

[iets247]

@girish thanks for the update...I confirm the installation now succeeds on the current version of Cloudron's bundledRedmine application when using the latest main branch of the plugin which includes the author's fix...