"Share this pad" Read-only on/off is ignored: guests do not have editing rights

[marylou]

Hello everyone,

I installed Etherpad today. When I opened it, I was logged in automatically, created a document, guests were able to join but without editing rights.

So I followed the instructions and changed /app/data/settings.json:

{
  "requireAuthentication": false,
  
  "users": {
    "admin": {
      // 1) "password" can be replaced with "hash" if you install ep_hash_auth
      // 2) please note that if password is null, the user will not be created
      "password": "changeme1",
      "is_admin": true
    },
    "user": {
      // 1) "password" can be replaced with "hash" if you install ep_hash_auth
      // 2) please note that if password is null, the user will not be created
      "password": "changeme1",
      "is_admin": false
    }
  }
}

Unfortunately, it did not change a thing.

Guests are not able to edit the document.

[nebulon]

I can confirm the read-only toggle really doesn't change anything. Not sure where the bug lies, etherpad develoment has picked up recently again, so many things had changed/broken/fixed. Maybe just a bug or it requires some very specific settings.

[Benoit]

I'm looking for a solution to share editable pads with guests without requiring them to log in, and I came across ep_mypads https://www.npmjs.com/package/ep_mypads, but it doesn't work on Cloudron. As of today, Etherpad is unusable in shared pad mode on Cloudron, as shown in this thread. On Framapad, it works using the MyPads plugin. Do you think it would be possible to make Cloudron compatible with this plugin? Is there another solution? Thanks for your help!

[Benoit]

Poke @girish @nebulon Whenever you have a solution, I would be very interested as I’ve been asked about it several times. Thank you!

[nebulon]

Do you know why this plugin is not working? Are there any errors or are the auth provider plugins incompatible?

[nebulon]

Have you checked out the openid plugins readme, especially the section about guests yet? https://github.com/ether/ep_openid_connect?tab=readme-ov-file#interaction-with-the-ep_guest-plugin

[Benoit]

@nebulon When I deploy this plugin from the Etherpad admin interface on Cloudron, it crashes. Here are the logs :

Dec 20 14:32:13 [2024-12-20T13:32:13.957] [INFO] plugins - Installing plugin ep_mypads...
Dec 20 14:32:13 [2024-12-20T13:32:13.957] [DEBUG] SessionStore - TOUCH zOkPdTTzxpQbrAHdFsV0hlsYxqtrP8tf
Dec 20 14:32:13 [2024-12-20T13:32:13.957] [DEBUG] SessionStore - TOUCH zOkPdTTzxpQbrAHdFsV0hlsYxqtrP8tf
Dec 20 14:32:20 [2024-12-20T13:32:20.478] [DEBUG] http - 200, GET /health
Dec 20 14:32:22 [2024-12-20T13:32:22.477] [DEBUG] SessionStore - TOUCH zOkPdTTzxpQbrAHdFsV0hlsYxqtrP8tf
Dec 20 14:32:22 [2024-12-20T13:32:22.477] [DEBUG] SessionStore - TOUCH zOkPdTTzxpQbrAHdFsV0hlsYxqtrP8tf
Dec 20 14:32:27 [2024-12-20T13:32:27.009] [ERROR] settings - Error reading package.json Error: ENOENT: no such file or directory, open '/run/etherpad-lite/src/plugin_packages/@types/ldapjs/package.json' for file:///run/etherpad-lite/src/plugin_packages/@types/ldapjs/package.json
Dec 20 14:32:27 [2024-12-20T13:32:27.010] [ERROR] settings - Error reading package.json Error: ENOENT: no such file or directory, open '/run/etherpad-lite/src/plugin_packages/@types/node/package.json' for file:///run/etherpad-lite/src/plugin_packages/@types/node/package.json
Dec 20 14:32:27 [2024-12-20T13:32:27.027] [INFO] plugins - Successfully installed plugin ep_mypads
Dec 20 14:32:27 [2024-12-20T13:32:27.030] [INFO] plugins - Loading plugin ep_align...
Dec 20 14:32:27 [2024-12-20T13:32:27.032] [INFO] plugins - Loading plugin ep_embedded_hyperlinks2...
Dec 20 14:32:27 [2024-12-20T13:32:27.032] [INFO] plugins - Loading plugin ep_openid_connect...
Dec 20 14:32:27 [2024-12-20T13:32:27.034] [INFO] plugins - Loading plugin ep_user_displayname...
Dec 20 14:32:27 [2024-12-20T13:32:27.036] [INFO] plugins - Loading plugin ep_stable_authorid...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_comments_page...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_font_color...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_headings2...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_markdown...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_guest...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_mypads...
Dec 20 14:32:27 [2024-12-20T13:32:27.037] [INFO] plugins - Loading plugin ep_etherpad-lite...
Dec 20 14:32:27 [2024-12-20T13:32:27.045] [INFO] plugins - Loaded 12 plugins
Dec 20 14:32:27 [2024-12-20T13:32:27.350] [DEBUG] server - unhandled rejection: TypeError: Cannot read properties of undefined (reading 'call')
Dec 20 14:32:27 at Database.set (/run/etherpad-lite/node_modules/.pnpm/ueberdb2@5.0.6/node_modules/ueberdb2/dist/index.js:343429:29)
Dec 20 14:32:27 at setK (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:190:46)
Dec 20 14:32:27 at done (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:195:9)
Dec 20 14:32:27 at module.exports.storage.fn.setKeys (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:200:5)
Dec 20 14:32:27 at Object.init (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/configuration.js:228:18)
Dec 20 14:32:27 at module.exports.hooks.init [as hook_fn] (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/hooks.js:46:19)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:273:18)
Dec 20 14:32:27 at new Promise (<anonymous>)
Dec 20 14:32:27 at callHookFnAsync (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:236:16)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:351:54)
Dec 20 14:32:27 at Array.map (<anonymous>)
Dec 20 14:32:27 at Object.exports.aCallAll (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:351:13)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/plugins.ts:120:17)
Dec 20 14:32:27 at Array.map (<anonymous>)
Dec 20 14:32:27 at Object.exports.update (/run/etherpad-lite/src/static/js/pluginfw/plugins.ts:118:47)
Dec 20 14:32:27 at async onAllTasksFinished (/run/etherpad-lite/src/static/js/pluginfw/installer.ts:28:3)
Dec 20 14:32:27 [2024-12-20T13:32:27.360] [DEBUG] server - uncaught exception: TypeError: Cannot read properties of undefined (reading 'call')
Dec 20 14:32:27 at Database.set (/run/etherpad-lite/node_modules/.pnpm/ueberdb2@5.0.6/node_modules/ueberdb2/dist/index.js:343429:29)
Dec 20 14:32:27 at setK (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:190:46)
Dec 20 14:32:27 at done (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:195:9)
Dec 20 14:32:27 at module.exports.storage.fn.setKeys (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:200:5)
Dec 20 14:32:27 at Object.init (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/configuration.js:228:18)
Dec 20 14:32:27 at module.exports.hooks.init [as hook_fn] (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/hooks.js:46:19)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:273:18)
Dec 20 14:32:27 at new Promise (<anonymous>)
Dec 20 14:32:27 at callHookFnAsync (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:236:16)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:351:54)
Dec 20 14:32:27 at Array.map (<anonymous>)
Dec 20 14:32:27 at Object.exports.aCallAll (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:351:13)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/plugins.ts:120:17)
Dec 20 14:32:27 at Array.map (<anonymous>)
Dec 20 14:32:27 at Object.exports.update (/run/etherpad-lite/src/static/js/pluginfw/plugins.ts:118:47)
Dec 20 14:32:27 at async onAllTasksFinished (/run/etherpad-lite/src/static/js/pluginfw/installer.ts:28:3)
Dec 20 14:32:27 [2024-12-20T13:32:27.363] [ERROR] server - Metrics at time of fatal error:
Dec 20 14:32:27 {
Dec 20 14:32:27 "httpStartTime": 1734665584973,
Dec 20 14:32:27 "memoryUsage": 289435648,
Dec 20 14:32:27 "memoryUsageHeap": 164299288,
Dec 20 14:32:27 "ueberdb_lockAwaits": 2,
Dec 20 14:32:27 "ueberdb_lockAcquires": 19,
Dec 20 14:32:27 "ueberdb_lockReleases": 19,
Dec 20 14:32:27 "ueberdb_reads": 15,
Dec 20 14:32:27 "ueberdb_readsFailed": 0,
Dec 20 14:32:27 "ueberdb_readsFinished": 15,
Dec 20 14:32:27 "ueberdb_readsFromCache": 13,
Dec 20 14:32:27 "ueberdb_readsFromDb": 2,
Dec 20 14:32:27 "ueberdb_readsFromDbFailed": 0,
Dec 20 14:32:27 "ueberdb_readsFromDbFinished": 2,
Dec 20 14:32:27 "ueberdb_writes": 4,
Dec 20 14:32:27 "ueberdb_writesFailed": 0,
Dec 20 14:32:27 "ueberdb_writesFinished": 4,
Dec 20 14:32:27 "ueberdb_writesObsoleted": 1,
Dec 20 14:32:27 "ueberdb_writesToDb": 3,
Dec 20 14:32:27 "ueberdb_writesToDbFailed": 0,
Dec 20 14:32:27 "ueberdb_writesToDbFinished": 3,
Dec 20 14:32:27 "ueberdb_writesToDbRetried": 0,
Dec 20 14:32:27 "totalUsers": 1,
Dec 20 14:32:27 "activePads": 0,
Dec 20 14:32:27 "httpRequests": {
Dec 20 14:32:27 "meter": {
Dec 20 14:32:27 "mean": 0.10012023831498443,
Dec 20 14:32:27 "count": 3600,
Dec 20 14:32:27 "currentRate": 0.10012023936428933,
Dec 20 14:32:27 "1MinuteRate": 0.14633223346479685,
Dec 20 14:32:27 "5MinuteRate": 0.11299891131843687,
Dec 20 14:32:27 "15MinuteRate": 0.10458847955209875
Dec 20 14:32:27 },
Dec 20 14:32:27 "histogram": {
Dec 20 14:32:27 "min": 0.48008299991488457,
Dec 20 14:32:27 "max": 212.56629499979317,
Dec 20 14:32:27 "sum": 28708.71706289379,
Dec 20 14:32:27 "variance": 366.7964638510959,
Dec 20 14:32:27 "mean": 7.9746436285816085,
Dec 20 14:32:27 "stddev": 19.151931073682775,
Dec 20 14:32:27 "count": 3600,
Dec 20 14:32:27 "median": 0.9069640021771193,
Dec 20 14:32:27 "p75": 2.1631570011377335,
Dec 20 14:32:27 "p95": 38.42079889997833,
Dec 20 14:32:27 "p99": 83.57729682140055,
Dec 20 14:32:27 "p999": 165.63424265441304
Dec 20 14:32:27 }
Dec 20 14:32:27 }
Dec 20 14:32:27 }
Dec 20 14:32:27 [2024-12-20T13:32:27.363] [ERROR] server - TypeError: Cannot read properties of undefined (reading 'call')
Dec 20 14:32:27 at Database.set (/run/etherpad-lite/node_modules/.pnpm/ueberdb2@5.0.6/node_modules/ueberdb2/dist/index.js:343429:29)
Dec 20 14:32:27 at setK (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:190:46)
Dec 20 14:32:27 at done (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:195:9)
Dec 20 14:32:27 at module.exports.storage.fn.setKeys (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/storage.js:200:5)
Dec 20 14:32:27 at Object.init (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/configuration.js:228:18)
Dec 20 14:32:27 at module.exports.hooks.init [as hook_fn] (/run/etherpad-lite/src/plugin_packages/.versions/ep_mypads@1.7.25/hooks.js:46:19)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:273:18)
Dec 20 14:32:27 at new Promise (<anonymous>)
Dec 20 14:32:27 at callHookFnAsync (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:236:16)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:351:54)
Dec 20 14:32:27 at Array.map (<anonymous>)
Dec 20 14:32:27 at Object.exports.aCallAll (/run/etherpad-lite/src/static/js/pluginfw/hooks.ts:351:13)
Dec 20 14:32:27 at <anonymous> (/run/etherpad-lite/src/static/js/pluginfw/plugins.ts:120:17)
Dec 20 14:32:27 at Array.map (<anonymous>)
Dec 20 14:32:27 at Object.exports.update (/run/etherpad-lite/src/static/js/pluginfw/plugins.ts:118:47)
Dec 20 14:32:27 at async onAllTasksFinished (/run/etherpad-lite/src/static/js/pluginfw/installer.ts:28:3)
Dec 20 14:32:27 [2024-12-20T13:32:27.363] [INFO] server - Exiting...
Dec 20 14:32:27 [2024-12-20T13:32:27.363] [INFO] server - Stopping Etherpad...
Dec 20 14:32:27 [2024-12-20T13:32:27.364] [INFO] http - Closing HTTP server...
Dec 20 14:32:27 [2024-12-20T13:32:27.364] [INFO] socket.io - Closing socket.io engine...
Dec 20 14:32:27 [2024-12-20T13:32:27.386] [INFO] socket.io - All socket.io clients have disconnected
Dec 20 14:32:27 [2024-12-20T13:32:27.388] [INFO] ueberDB - Database closed
Dec 20 14:32:27 [2024-12-20T13:32:27.388] [INFO] http - Waiting for 1 HTTP clients to disconnect...
Dec 20 14:32:27 [2024-12-20T13:32:27.400] [INFO] http - HTTP server closed
Dec 20 14:32:27 [2024-12-20T13:32:27.400] [DEBUG] secret-rotation expressSessionSecrets - stopping secret rotation
Dec 20 14:32:27 [2024-12-20T13:32:27.401] [INFO] server - Etherpad stopped
Dec 20 14:32:27 [2024-12-20T13:32:27.401] [INFO] server - Waiting for Node.js to exit...
Dec 20 14:32:30 => Healtheck error: Error: connect ECONNREFUSED 172.18.17.6:9001
Dec 20 14:32:32 [2024-12-20T13:32:32.406] [ERROR] server - Something that should have been cleaned up during the shutdown hook (such as a timer, worker thread, or open connection) is preventing Node.js from exiting
Dec 20 14:32:32 [2024-12-20T13:32:32.407] [ERROR] server - Enable `dumpOnUncleanExit` setting to get a dump of objects preventing a clean exit
Dec 20 14:32:32 [2024-12-20T13:32:32.420] [ERROR] server - Forcing an unclean exit...
Dec 20 14:32:32 /run/etherpad-lite/src:
Dec 20 14:32:32  ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  ep_etherpad-lite@2.2.6 dev: `cross-env NODE_ENV=development node --require tsx/cjs node/server.ts "--settings" "/run/etherpad-lite/settings.json" "--credentials" "/app/data/settings.json"`
Dec 20 14:32:32 Exit status 1
Dec 20 14:32:32  ELIFECYCLE  Command failed with exit code 1.
Dec 20 14:32:34 ==========================
Dec 20 14:32:34 Etherpad start
Dec 20 14:32:34 ==========================
Dec 20 14:32:34 => Ensure /app/data/settings.json
Dec 20 14:32:40 => Healtheck error: Error: connect ECONNREFUSED 172.18.17.6:9001

[Benoit]

@nebulon do you have an idea about this problem with ep_guest bug ? Thanks !

[nebulon]

not really, have you reported that upstream with the plugin project?

[Benoit]

Hi all,

I believe I've found a solution that works. With this setup, my logged-in users can create pads, and guests can edit them as long as read-only mode is not enabled by the pad owner. Guests, however, cannot create pads.

{
 "ep_guest": {
    "username": "guest"
  }, 
  "users": {
    "user1": {
      "is_admin": true
    },
    "guest": {
      "displayname": "Guest",
      "displaynameChangeable": false,
      "readOnly": false,
      "canCreate": false
    }
  }
}