Cloudron makes it easy to run web apps like WordPress, Nextcloud, GitLab on your server. Find out more or install now.


  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse

Cloudron Forum

Apps | Demo | Docs | Install

Bug: handling special characters in filenames

Scheduled Pinned Locked Moved Solved Surfer
7 Posts 2 Posters 315 Views
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • robiR Offline
    robiR Offline
    robi
    wrote on last edited by robi
    #1

    Just found another bug in Surfer: When you play a video you have a button "copy link". This button copies the original file name into the URL but doesn't translate special characters (e.g. space -> %20) so that the link will not work. Had to manually edit it for linking a file.

    There also doesn't appear to be a way to close the preview pane.

    Life of sky tech

    1 Reply Last reply
    2
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    wrote on last edited by
    #2

    Well spotted, although I don't think the space would have made your browser not being able to open that URL. Either way I've fixed this now, pending a package release.

    robiR 1 Reply Last reply
    2
  • robiR Offline
    robiR Offline
    robi
    replied to nebulon on last edited by
    #3

    @nebulon that is exactly what happened and how the bug was found.. it didn't open and needed editing.

    was there a preview pane close 'X' added?

    Life of sky tech

    1 Reply Last reply
    0
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    wrote on last edited by
    #4

    Yes also the filename is put back now.

    1 Reply Last reply
    1
  • robiR Offline
    robiR Offline
    robi
    wrote on last edited by
    #5

    Another issue is with #, Surfer doesn't seem to like it in filenames and can't serve those files with the webserver.

    Life of sky tech

    nebulonN 1 Reply Last reply
    0
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    replied to robi on last edited by
    #6

    @robi this should be fixed with https://git.cloudron.io/cloudron/surfer/-/commit/353ac1f5cb0c1da988e68ca35a417b35130b0d25 however before I release a new package I need to add more filepath encoding tests.

    nebulonN 1 Reply Last reply
    0
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    replied to nebulon on last edited by nebulon
    #7

    Ok I added those test cases and made a new package release now. Please be aware that if you just use # in a path in the browser URL bar, without encoding it, the browser will treat this as a URL hash, not as part of the filepath.

    eg. foo/bar#baz.txt will end up as foo/bar only.

    1 Reply Last reply
    1

  • Login

  • Don't have an account? Register

  • Login or register to search.
  • First post
    Last post
0
  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks