Solved Slow startup caused by fixing permissions in start.sh

[vladimir.d]

Can we have an option to disable fixing file permissions on startup or fix permissions later?
It takes 2-3 hours to start Nextcloud app (3Tb, ~2.5 million files).

[girish]

@vladimir-d Thanks, I have pushed a fix so we change permissions only when needed. We made a similar fix in minio some time ago as well.

https://git.cloudron.io/cloudron/nextcloud-app/-/commit/33d4721e7e8fba1ac3322ef39a0a211df18cffc2

[girish]

@vladimir-d Thanks, I have pushed a fix so we change permissions only when needed. We made a similar fix in minio some time ago as well.

https://git.cloudron.io/cloudron/nextcloud-app/-/commit/33d4721e7e8fba1ac3322ef39a0a211df18cffc2

[vladimir.d]

Looks good, looking forward for a new Nextcloud release.
Thank you.

[vladimir.d]

@girish could you also review the code on lines 10-11 of start.sh.
and can you move start.sh on writable fs?

[girish]

@vladimir-d So far a start, I have made the chown a bit like find /app/data \( -type f -or -type d \) -and ! -user www-data -exec chown www-data:www-data '{}' \+. That essentially checks file ownership before chowing them. I have also added a flag to skip chown for restarts.

If these two changes are not enough, then we have to add some more sophisticated check if files are already of the correct ownership or not.

[girish]

@vladimir-d Can you check if things are better with the latest update?