Cloudron makes it easy to run web apps like WordPress, Nextcloud, GitLab on your server. Find out more or install now.


    Cloudron Forum

    • Register
    • Login
    • Search
    • Categories
    • Recent
    • Tags
    • Popular

    Solved URL for open graph tag incorrect

    Rallly
    4
    9
    80
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • andreasdueren
      andreasdueren last edited by

      Currently the URL and image URL for the OG Tag are incorrect and therefore won't load.

      is:

      <meta property="og:url" content="http://localhost:3000">
      <meta property="og:type" content="website">
      <meta property="og:image" content="http://localhost:3000/og-image-1200.png">
      

      should be:

      <meta property="og:url" content="https://tld.url">
      <meta property="og:type" content="website">
      <meta property="og:image" content="/og-image-1200.png">
      

      Screenshot 2022-12-31 at 10.50.09.png

      1 Reply Last reply Reply Quote 1
      • nebulon
        nebulon Staff last edited by

        Looking through the code it seems we have to set some env variable for this as the urls are produced via https://github.com/lukevella/rallly/blob/main/src/utils/absolute-url.ts#L7

        andreasdueren 1 Reply Last reply Reply Quote 1
        • Topic has been marked as a question  nebulon nebulon 
        • andreasdueren
          andreasdueren @nebulon last edited by andreasdueren

          @nebulon Thats strange since that is not a suggested env and it's properly rendered on the rallly.co website. I opened a github issue.

          girish 1 Reply Last reply Reply Quote 2
          • girish
            girish Staff @andreasdueren last edited by

            @andreasdueren this is suggested in https://github.com/lukevella/rallly/blob/2c4157ea244a5eee05f25690346a9d6261d5c574/sample.env#L1 atleast. Looks like a packaging issue.

            M 1 Reply Last reply Reply Quote 1
            • M
              msbt App Dev @girish last edited by msbt

              @girish my original version works properly (also changing the language and such), I reckon the app needs to be able to write somewhere after changing things

              1 Reply Last reply Reply Quote 2
              • nebulon
                nebulon Staff last edited by

                Our package actually already sets this correctly at https://git.cloudron.io/cloudron/rallly-app/-/blob/main/start.sh#L32

                Seems like this needs further debugging why that value is not picked up correctly here.

                1 Reply Last reply Reply Quote 1
                • nebulon
                  nebulon Staff last edited by

                  I have commented in the upstream github issue about this. Basically we build the static assets for the app during Docker image build and thus the env variable for generating the websites is not yet set and anyways may change over time.

                  1 Reply Last reply Reply Quote 1
                  • girish
                    girish Staff last edited by

                    This got fixed upstream in https://github.com/lukevella/rallly/issues/378 and Cloudron package will pick this up in the coming release.

                    andreasdueren 1 Reply Last reply Reply Quote 2
                    • andreasdueren
                      andreasdueren @girish last edited by

                      @girish Nice thanks!

                      1 Reply Last reply Reply Quote 0
                      • Topic has been marked as solved  nebulon nebulon 
                      • First post
                        Last post
                      Powered by NodeBB