Solved URL for open graph tag incorrect

[andreasdueren]

Currently the URL and image URL for the OG Tag are incorrect and therefore won't load.

is:

<meta property="og:url" content="http://localhost:3000">
<meta property="og:type" content="website">
<meta property="og:image" content="http://localhost:3000/og-image-1200.png">

should be:

<meta property="og:url" content="https://tld.url">
<meta property="og:type" content="website">
<meta property="og:image" content="/og-image-1200.png">

[nebulon]

Looking through the code it seems we have to set some env variable for this as the urls are produced via https://github.com/lukevella/rallly/blob/main/src/utils/absolute-url.ts#L7

[andreasdueren]

@nebulon Thats strange since that is not a suggested env and it's properly rendered on the rallly.co website. I opened a github issue.

[girish]

@andreasdueren this is suggested in https://github.com/lukevella/rallly/blob/2c4157ea244a5eee05f25690346a9d6261d5c574/sample.env#L1 atleast. Looks like a packaging issue.

[msbt]

@girish my original version works properly (also changing the language and such), I reckon the app needs to be able to write somewhere after changing things

[nebulon]

Our package actually already sets this correctly at https://git.cloudron.io/cloudron/rallly-app/-/blob/main/start.sh#L32

Seems like this needs further debugging why that value is not picked up correctly here.

[nebulon]

I have commented in the upstream github issue about this. Basically we build the static assets for the app during Docker image build and thus the env variable for generating the websites is not yet set and anyways may change over time.

[girish]

This got fixed upstream in https://github.com/lukevella/rallly/issues/378 and Cloudron package will pick this up in the coming release.

[andreasdueren]

@girish Nice thanks!