10.6 SyncPlay Feature

[mehdi]

@nebulon I pushed a Merge Request and assigned it to you for review I tested it both as a fresh install and as an update, seems to work OK.

FYI, there's a bug in the LDAP plugin that affects river, but does not affect the Jellyfin app, as it does not use the ldap to set admin rights : https://github.com/jellyfin/jellyfin-plugin-ldapauth/issues/55

@girish I won't be able to take care of the VAAPI stuff I'm still on 16.04 and it's not compatible I think. If it's implemented in the Jellyfin app, I'll port it to River though.

[mehdi]

@nebulon Gentle reminder that the MR is waiting to be published

[nebulon]

Yes, I was actually commenting on that MR already, since for some reason the default admin account does not work anymore.

Not sure if it was removed entirely, changed default credentials or is not working? Maybe you can shed some light.

Also apparently the GitLab notifications don't work as expected

[mehdi]

@nebulon Sorry, I missed the comment (i would swear I checked before writing this comment, but apparently...)-_- my bad, I may have disabled the email notifications

I'll investigate the admin thing. I think I know why it does this.

[nebulon]

No worries at all, thanks for all the effort!

[mehdi]

@nebulon After a bit of investigation, it's even more annoying than it used to be to pre-create an admin user. I suggest to just display the install wizard on the first start, which allows the user to select the language, and create an admin user.

The migration for existing users should still work without problem, their existing admin will be migrated correctly, and they will not be shown the wizard.

Is this acceptable for you?

[nebulon]

Totally as long as the setup wizard only shows relevant setup steps to a user. Like doing database setup would not be useful to a user

[nebulon]

Just a heads up, the tests required quite some changes due to the update and are still failing and also flaky.

Last status is that after a restore the LDAP login does not work anymore. Have to debug this another day.

[mehdi]

@nebulon well, I wanted to fix up the test this week-end but you were faster than me ^^

About the LDAP not working after restore: I think it may be the symlink to the ldap plugin that's broken by the backup/restore process somehow. I'm not sure what may cause this, I think backups are supposed to work with symlinks, aren't they?

It's not a regression though, it worked the exact same way in the old version.

A simple fix would be to always re-create the symlink in the start.sh, instead of only doing it when initializing the config directory.

However, I cannot test this / debug any further : I do not have backups at all on my cloudron ^^" (I like to live dangerously :p)

[nebulon]

I pushed my current state to the repo, feel free to pick that up from there as far as you get

[mehdi]

@nebulon I just pushed (in a new MR) a commit that re-creates the LDAP plugin symlink in start.sh. I think it may solve the problem you reported. Could you test, and merge it if it works?

[nebulon]

Thanks, it seems to fix the issue so I merged it. Currently fixing up update tests before I make the release.