Apps with disabled backups shouldn't default to backup during update

[necrevistonnezr]

I just tried to update Navidrome. I have backups disabled since my (quite big) music folder is mounted into the app (until Cloudron 6 comes along...) and I don't want the music folder in my backup.
When I hit "update", I forgot to check "skip update" since I thought that backups are disabled, anyway.

Yet it started backing up everything so I hit "cancel". Now the app is in error state ("Task Error: Task 5248 stopped") - how do I get out of that without resuming backup and update?

[imc67]

@necrevistonnezr same experience here with Navidrome but also Minio

[girish]

@necrevistonnezr If you got to repair view, there will be a button to 'Retry update'. Despite what the button says, it doesn't retry the update. It just brings the app back up. I will get the text fixed next release. You can then try to update it again, skipping backup.

[d19dotca]

@girish I suppose in that scenario too the update dialogue should already have the "skip backup" checked by default.

[girish]

@d19dotca the text itself is wrong. it doesn't update, it actually just brings the application back up (it's a "repair" action)

[d19dotca]

@girish I think I'm referring to the other part. @necrevistonnezr is saying that when he hit update, it started to backup the app which he didn't want because it was set to have backups disabled. Unless I misunderstood, but I would think in that scenario if the app has backups disabled then the "Skip backup" option when updating an app should be enabled by default, right? Or did I misunderstand? Sorry if I did. Been a crazy day today lol.

[nebulon]

Yes that checkbox is not seeded with any value but is off by default. I guess it makes sense to fix this to preset it with the backup config for that app.

[nebulon]

This is now fixed with https://git.cloudron.io/cloudron/dashboard/-/commit/01de0250acb69f5cd696f677fca30907d4f8e188

[d19dotca]

@nebulon It's insane to me how quick you guys are, haha. Thank you!

[nebulon]

@girish hinted, that this needs more vetting here. So if that app would have been auto-updated, then a backup would have been made, regardless of automatic backups or not.

That in its own may or may not be what one would expect.

Either way to be consistent at least, I will change that to have the skip backup checkbox set by default only if automatic updates and backups are disabled.

Edit: pushed the new fix