Chat logs lost after update from 1.19 -> 1.20

[jdaviescoates]

@infogulch said in Chat logs lost after update from 1.19 -> 1.20:

@jdaviescoates In case you haven't already, I would strongly recommend that you pin the latest 1.19 backup so that it's not automatically cleaned up before this is sorted out.

Thanks, good idea! But in my case I'm really not bothered about this as there aren't really any important messages there.

[infogulch]

Ok well the new update loses chat logs again. I guess I can't use cloudron for irc.

[jdaviescoates]

@nebulon said in Chat logs lost after update from 1.19 -> 1.20:

I wonder how we can reproduce this.

Try what @infogulch suggested above?

[girish]

@infogulch @jdaviescoates the package incorrectly assumes that logs directory is app logs. It's actually the irc logs (messages). I am making a new package.

Usually, this is caught in our tests... But unfortunately, thelounge has no proper tests because this is not easy to test....

[girish]

New package is out. Unfortunately, the old versions still lose the irc logs

[infogulch]

Backups cover a lot of sins. I still have the archived backup from the last time this happened.

Now we need a process for restoring the chat logs. I guess we can start by cloning the app from an old backup, but I'm not sure how to copy files between containers. Any ideas?

[infogulch]

Oh. So because logs were assumed to be app logs and redirected to the ephemeral /run directory so they were not backed up.

How did this issue persist when we had a whole discussion about how logs are chat logs not app logs nearly 6 months ago?

[infogulch]

I updated to package version io.github.thelounge@1.20.1-1 and I still see that logs is a symlink to the ephemeral run directory:

[girish]

@infogulch said in Chat logs lost after update from 1.19 -> 1.20:

Oh. So because logs were assumed to be app logs and redirected to the ephemeral /run directory so they were not backed up.

yes, pretty much

How did this issue persist when we had a whole discussion about how logs are chat logs not app logs nearly 6 months ago?

I think this just fell through the cracks. We didn't investigate further and lost track.

[girish]

@infogulch said in Chat logs lost after update from 1.19 -> 1.20:

I updated to package version io.github.thelounge@1.20.1-1 and I still see that logs is a symlink to the ephemeral run directory:

My bad, that symlink has to get deleted. I pushed another package now, can you please check?

[infogulch]

It looks like it's working now.