Cloudron makes it easy to run web apps like WordPress, Nextcloud, GitLab on your server. Find out more or install now.


  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse

Cloudron Forum

Apps | Demo | Docs | Install

Is it possible to add comments to the Network > IP Blocklist?

Scheduled Pinned Locked Moved Discuss
8 Posts 3 Posters 323 Views
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • d19dotcaD Offline
    d19dotcaD Offline
    d19dotca
    wrote on last edited by
    #1

    Trying to add in an IP address to the IP Blocklist in Cloudron, and was going to add in a comment to each line item beside the IP so I can add notes about why it's being blocked, etc. Is this possible? I tried adding in \\ before the comment and after then IP address but it didn't accept it, same with /* <comment */, and # <comment>, etc. Nothing seems to work, so I'm thinking this isn't possible yet. If I'm missing something though, please let me know.

    --
    Dustin Dauncey
    www.d19.ca

    humptydumptyH 1 Reply Last reply
    1
  • humptydumptyH Offline
    humptydumptyH Offline
    humptydumpty
    replied to d19dotca on last edited by
    #2

    @d19dotca This option seems to contradict what I've read in this post: https://forum.cloudron.io/topic/4664/restrict-dashboard-access-cloudron-v6-1-2?_=1615815159854

    It seems you'll have to do it in the firewall with your host.

    d19dotcaD 1 Reply Last reply
    0
  • d19dotcaD Offline
    d19dotcaD Offline
    d19dotca
    replied to humptydumpty on last edited by
    #3

    @humptydumpty I believe that's a different use-case. In their case they were trying to forbid IPs only to their Dashboard, but presumably to other client apps. The Cloudron network firewall is basically an "all or nothing" firewall, to my knowledge so that's why that user couldn't do that for their use-case as they wanted it to succeed somewhere but fail somewhere else, and that can't be done.

    I want mine to fail everywhere as designed, just also the ability to add some comments beside an IP where I could write the mail server name or something for example.

    --
    Dustin Dauncey
    www.d19.ca

    1 Reply Last reply
    1
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    wrote on last edited by
    #4

    This is supported. As far as the code goes, a comment is done with a prefix of # comment. Looking at the section there, the # has to be the first character in the line though. https://git.cloudron.io/cloudron/box/-/blob/master/src/network.js#L35

    d19dotcaD 1 Reply Last reply
    2
  • d19dotcaD Offline
    d19dotcaD Offline
    d19dotca
    replied to nebulon on last edited by d19dotca
    #5

    @nebulon Oh I see, okay so I can add in comments but just not on the same line as the IP address. What I was trying to do was something like 111.111.111.111 # spammy mail server

    I see it works though if I write it like this then:

    # spammy mail server
    111.111.111.111
    

    Thanks man! 🙂

    --
    Dustin Dauncey
    www.d19.ca

    nebulonN 1 Reply Last reply
    1
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    replied to d19dotca on last edited by
    #6

    @d19dotca indeed that is correct, I guess we could improve the file parser at some point later, if this comes up more often.

    d19dotcaD 1 Reply Last reply
    0
  • d19dotcaD Offline
    d19dotcaD Offline
    d19dotca
    replied to nebulon on last edited by d19dotca
    #7

    @nebulon I've created a merge request for updating the documentation to note about comments in the IP blocklist function.

    --
    Dustin Dauncey
    www.d19.ca

    nebulonN 1 Reply Last reply
    1
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    replied to d19dotca on last edited by
    #8

    @d19dotca thanks! I've merged it

    1 Reply Last reply
    1

  • Login

  • Don't have an account? Register

  • Login or register to search.
  • First post
    Last post
0
  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks
  • Login

  • Don't have an account? Register

  • Login or register to search.