File Manager Upload Overwrite & Rename

[robi]

@nebulon

The CL FM will accept for upload a nice large file, then once it finishes and realizes there is another file by the same name, it will ask if one wants to Overwrite.

So far so good, however if you click the overwrite button, the upload starts again.

Then, after it finishes the 2nd upload, it asks you if you want to Rename the file?!?

Then, you only end up with the file you uploaded, but were seemingly forced to rename it.

[nebulon]

@robi I admit this is far from smart, but was just a fast way to deal with it. The filemanager was not built in mind for uploading large files, but more like managing config files. Will see what can be done to fix this better.

[robi]

Cloudron backups are pretty good if mistakes are made.

How about check filename dup first and pop up the modal for Overwrite, if yes, move the temp file and overwrite, if no, move the temp file to .1, .2, .3 etc..

Definitely avoid a second upload.

[nebulon]

This is now fixed for the next version. On upload conflict, the code will add .n to the filepath, whereas n is an increasing number until no conflict is found.