ReleaseBell: a `website` project is accepted by the API but never syncs

[LoudLemur]

Read against eb9d805. Second of three small findings from the same read.

routes.js:123 accepts three project types when adding one:

if ([ database.PROJECT_TYPE_GITHUB_MANUAL, database.PROJECT_TYPE_GITLAB, database.PROJECT_TYPE_WEBSITE ].indexOf(req.body.type) === -1) return next(new HttpError(400, 'invalid type'));

But syncReleasesByProject has no branch for website (tasks.js:152-161), so it falls through to the "unknown type" case and returns — before lastSuccessfulSyncAt is set at line 217.

So the row is stored, never syncs, never errors, and is indistinguishable in the UI from a project that simply has no new releases. Someone who adds one waits indefinitely for a notification that cannot arrive.

If a website backend is not imminent, the cheapest honest fix is to stop accepting the type until something consumes it:

-    if ([ database.PROJECT_TYPE_GITHUB_MANUAL, database.PROJECT_TYPE_GITLAB, database.PROJECT_TYPE_WEBSITE ].indexOf(req.body.type) === -1)
+    if ([ database.PROJECT_TYPE_GITHUB_MANUAL, database.PROJECT_TYPE_GITLAB ].indexOf(req.body.type) === -1)

Worth keeping the constant and the project_type migration either way, since website watching is an obvious future feature.

[girish]

Fixed