[Feature Request] Email Updates

[girish]

@thetomester13 thanks! I merged it. It seems that highlight.js which comes from helper-markdown is deprecated. I see this when installing (there's upstream issues https://github.com/helpers/helper-markdown/issues/15 and https://github.com/helpers/helper-markdown/issues/14 about this):

> highlight.js@9.18.5 postinstall /home/girish/yellowtent/releasebell/node_modules/highlight.js
> node deprecated.js

-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*

  Verion 9 of Highlight.js has reached EOL.  It will no longer
  be supported or receive security updates in the future.
  Please upgrade to version 10 or encourage your indirect
  dependencies to do so.

  For more info:
  
  https://github.com/highlightjs/highlight.js/issues/2877
  https://github.com/highlightjs/highlight.js/blob/master/VERSION_10_UPGRADE.md
 
-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*-*

[girish]

@thetomester13 Given that it's really just one file - https://github.com/helpers/helper-markdown/blob/master/index.js, do you think we can just remove usage of that module entirely? Just put that file in releasebell itself (or make a function) and bump the deps?

[thetomester13]

@girish yikes, totally missed the fact that helpers/helper-markdown is not really supported anymore, quite unfortunate as it seems the author just stopped responding

do you think we can just ... put that file in releasebell itself (or make a function) and bump the deps?

Anyway, yes, I think this is a fine way to move forward. Unfortunately, the now-deprecated module was the best solution I found to render Markdown in handlebars. And as you mentioned, since it's quite straight forward, pulling it into ReleaseBell probably wouldn't be a big deal. Even more so, I don't believe we use the hightlight method defined on line 40, so we shouldn't even need to bring in the highlight.js package.

[nebulon]

@thetomester13 I guess in the long run we can move this to markdown-it which seems to be properly supported

[thetomester13]

@nebulon that's a great point! I was always looking at how to integrate Markdown rendering with the Handlebars templating, but we could simply try to get Markdown as HTML and then pass it into the email template.

[nebulon]

@thetomester13 we are running the new version currently for testing still and it is a huge improvement. Thanks @thetomester13 totally worth it

[girish]

Indeed, it's pretty great. In fact, just one day in, I don't know how I lived without this for so long

(on a side note, there was a crash which I have fixed).

[thetomester13]

that makes me happy to hear! Glad I can contribute!

@girish curious, what was causing the crash?

[robi]

@girish said in [Feature Request] Email Updates:

Indeed, it's pretty great. In fact, just one day in, I don't know how I lived without this for so long

What's the workflow that so much better?

[girish]

@robi the release information is now straight in the new release notitfication email. Previously, one had to click through and visit via the browser etc.

[thetomester13]

@girish @nebulon any idea when the new version will be pushed out? I'm still on the official Cloudron Store version, so don't have these updates yet.

[nebulon]

@thetomester13 ah yes, sorry forgot about this. We are using it already for some time now and initial issues were fixed, so no reason not to update it. Will go ahead now.

[nebulon]

Updated now