Favicon fix ?

[nebulon]

Do you have a link to the upstream docs mentioning support for this? The app got quite some heavy changes in the past UI wise.

[Neluser]

@nebulon

Is that what you mean?
I looked at the documentation on github.

https://github.com/Stirling-Tools/Stirling-PDF

[nebulon]

At least nothing really changed on that packaging side in this, so maybe this is an upstream regression, especially if other icons still work. Have you searched the issues there and maybe raised one?

[froodle]

Not sure what is happening here, i can still change the icon in the base package, we have not made any updates to this functionality in a long time

[joseph]

@Neluser @froodle looks like customStaticFilePath was removed in https://github.com/Stirling-Tools/Stirling-PDF/commit/45e2623b9bcb7b88a179553535b82929293bc18b#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L245 . So, the favicon cannot be customized anymore .

Not sure what is happening here, i can still change the icon in the base package

I guess you mean that you have to re-build the binary by replacing the favicon, correct?

[froodle]

That change is to remove the config to change the path as it never actually worked
It is instead hard coded to .\customFiles\static
I can still customise this on latest version with a favicon.svg file placed in that folder

[nebulon]

I've just tried to reproduce this, placing a favicon.svg in that folder will serve that up fine, however the actual favicon seems to be /favicon-16x16.png in the end also after an app restart. Do we need to run some command to regenerate assets in the app package?

The app icon in various places has changed correctly.

[froodle]

So the way it works on stirling side is we just grab whatever files are in static if their naming and path is the same on stirling pdf side
In this case any files you place will override any files placed in here
https://github.com/Stirling-Tools/Stirling-PDF/tree/main/src/main/resources/static

since you want to override the favicon itself then you would nee dto change favicon.svg for the homepage icons and favicon-16x16.png etc for the favicon itself (smaller sizes for better loading on SSO side)

[nebulon]

Oh that makes total sense, I can confirm it works by placing file accordingly. So I guess this issue is resolved by @Neluser probably having to put more custom files for the favicons?

[joseph]

@froodle thanks! Can confirm that it works after placing some icons like this:

[Neluser]

Hi, yes indeed when I uploaded some image variations I got everything working.

In my case the favicon.ico was applied, not the favicon.svg.

Thank you all for your help in solving my issue.