-
@malvim Wow, that's some incredible progress! If the status indicator is green, it's pretty sure that the addon containers are responding to health checks!
For the test for the addons, there is a test/ inside the repo of each addon. You can just do
npm installandnpm test. -
To be clearer, like this (say with postgres addon). The tests will always test the latest
cloudron/{addonname}testimage.$ docker build -t cloudron/postgresqladdontest . $ cd test $ npm install # only have to do this once $ npm test > postgresql-addon@1.0.0 test /home/girish/yellowtent/postgresql-addon > mocha --bail ./test/test.js Postgresql Addon Error response from daemon: network with name cloudron already exists auth ✓ fails without access_token ✓ fails with invalid access_token ✓ succeeds add database ✓ succeeds (410ms) ✓ succeeds when added again remove database ✓ succeeds (140ms) use the database ✓ can create extension (49ms) ✓ can create table foo ✓ can insert into table foo ✓ can read from table foo ✓ restart (5241ms) ✓ can read from table foo backup and restore ✓ succeeds to create backup (392ms) ✓ succeeds to create new database (422ms) ✓ succeeds to clear new database (449ms) ✓ succeeds to restore backup (875ms) ✓ succeeds to check restore data (47ms) restore of invalid dump fails ✓ succeeds to create backup (175ms) ✓ succeeds to clear new database (434ms) ✓ fails to restore backup (174ms) restore of existing dump ✓ succeeds (1895ms) 21 passing (35s) -
Hey, @girish!
So I was trying to run the tests on the raspberry pi, had some failures, but they're also failing on my regular amd64 laptop with ubuntu, so I'm not sure what's going on.
I tried specifically the postgresql addon like you mentioned, with no changes, the
authandadd databasetests pass, but I always get a timeout on theremove databasetest, every time. Mail and sftp addon also fail at different points, so I'm not trusting the failed tests on the rpi.I thought about trying to run the tests on my production cloudron server, but not sure I should.
Have you ever been through this?
-
Okay, so I ran the tests on my production cloudron and they all passed. It seems they don't run on a regular machine previously to installing cloudron? Is that true? And SHOULD they? Maybe I'm testing it wrong heheh.
But it would be nice if we could just run the tests outside of any cloudron installation, so I could test the images themselves, separately, on arm64 before going with another full install.
What do you guys say?
-
@malvim said in Cloudron on a Raspberry pi?:
Okay, so I ran the tests on my production cloudron and they all passed. It seems they don't run on a regular machine previously to installing cloudron? Is that true? And SHOULD they? Maybe I'm testing it wrong heheh.
Your steps for testing it on local are different right? Since production is already running. What are your testing steps in each scenario?
But it would be nice if we could just run the tests outside of any cloudron installation, so I could test the images themselves, separately, on arm64 before going with another full install.
What do you guys say?
I'd say that's possible. We could just use Docker itself? That's what I do locally.
Anyway, what Rasberry Pi are you developing this on? I'll go run out and get one to see if I run into similar issues.
️ Very interested in Cloudron on ARM in 2030! -
@Lonk said in Cloudron on a Raspberry pi?:
Your steps for testing it on local are different right? Since production is already running. What are your testing steps in each scenario?
Yeah, I'm doing what @girish outlined in his latest response in this thread: clone an addon repo,
docker buildthe image tagging it with whatever name the test runner uses (cloudron/postgresqladdontestin this case),npm installandnpm test.It turns out I'm getting failures in all that I've tried so far, so I don't feel comfortable saying I "have successfully built the images" when I can't run the tests. But I can't run them on my laptop as well, so who knows? Haha!
Anyway, what Rasberry Pi are you developing this on? I'll go run out and get one to see if I run into similar issues.
️ Very interested in Cloudron on ARM in 2030!I had never played with one till this year, they're fun! I got the latest model, the Raspberry Pi 4. Powerful little thing! It'd be great to have another pair of hands on this.
-
@malvim Well, consider yourself not alone in this endeavor! I'd love to help and am very interested in porting this to arm. Depends on the number of dependencies from the base image as well as Cloudron itself.
I'll post back here when I get my Raspberry Pi; I'm excited!
️ -
@girish said in Cloudron on a Raspberry pi?:
@malvim We never run tests on the Cloudron itself, only on the laptop! Can you give the output of the
npm testcommand? What is the error?malvim@zem:~/docker/postgresql-addon/test$ npm i audited 152 packages in 2.419s found 3 vulnerabilities (2 low, 1 high) run `npm audit fix` to fix them, or `npm audit` for details malvim@zem:~/docker/postgresql-addon/test$ npm test > postgresql-addon@1.0.0 test /home/malvim/docker/postgresql-addon > mocha --bail ./test/test.js Postgresql Addon Error: No such container: postgresql auth ✓ fails without access_token ✓ fails with invalid access_token ✓ succeeds add database ✓ succeeds (676ms) ✓ succeeds when added again (124ms) remove database 1) succeeds 5 passing (2m) 1 failing 1) Postgresql Addon remove database succeeds: Error: Timeout of 100000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/malvim/docker/postgresql-addon/test/test.js) at listOnTimeout (internal/timers.js:554:17) at processTimers (internal/timers.js:497:7)Hey, @girish!
This is the output, and it just hangs after that and never exits. This happens on my laptop and on another machine I used for testing purposes. On my Cloudron, these tests passed and only the last one failed, the backup/restore one iirc.
-
@robi said in Cloudron on a Raspberry pi?:
@malvim said in Cloudron on a Raspberry pi?:
Postgresql Addon
Error: No such container: postgresql
auththis seems to be more of a problem than the timeout later
It's really not. This happens because the test always tries to remove the currentl running postgresql container before running the tests, so the first time you run, the container is not running and you get this message. Still runs the tests and some of them work.
-
@girish said in Cloudron on a Raspberry pi?:
Is there anything in
docker logs -f postgresql?Nothing that I thought was strange... Here's the output:
Creating new installation [39/54] The files belonging to this database system will be owned by user "postgres". This user must also own the server process. The database cluster will be initialized with locale "C". The default text search configuration will be set to "english". Data page checksums are disabled. fixing permissions on existing directory /var/lib/postgresql/11/main ... ok creating subdirectories ... ok selecting default max_connections ... 100 selecting default shared_buffers ... 128MB selecting default timezone ... Etc/UTC selecting dynamic shared memory implementation ... posix creating configuration files ... ok running bootstrap script ... ok performing post-bootstrap initialization ... ok syncing data to disk ... ok WARNING: enabling "trust" authentication for local connections You can change this by editing pg_hba.conf or using the option -A, or --auth-local and --auth-host, the next time you run initdb. Success. You can now start the database server using: /usr/lib/postgresql/11/bin/pg_ctl -D /var/lib/postgresql/11/main -l logfile start CREATE ROLE ALTER ROLE waiting for server to shut down.... done server stopped Generating SSL certificate Generating a RSA private key .......................+++++ .....................................................................+++++ writing new private key to '/run/postgresql.cloudron.key' ----- Starting supervisor 2020-10-21 01:20:33,612 CRIT Supervisor running as root (no user in config file) 2020-10-21 01:20:33,613 INFO Included extra file "/etc/supervisor/conf.d/postgresql-service.conf" during parsing 2020-10-21 01:20:33,613 INFO Included extra file "/etc/supervisor/conf.d/postgresql.conf" during parsing 2020-10-21 01:20:33,628 INFO RPC interface 'supervisor' initialized 2020-10-21 01:20:33,628 CRIT Server 'inet_http_server' running without any HTTP authentication checking 2020-10-21 01:20:33,630 INFO RPC interface 'supervisor' initialized 2020-10-21 01:20:33,631 CRIT Server 'unix_http_server' running without any HTTP authentication checking 2020-10-21 01:20:33,631 INFO supervisord started with pid 1 2020-10-21 01:20:34,635 INFO spawned: 'postgresql' with pid 53 2020-10-21 01:20:34,639 INFO spawned: 'postgresql-service' with pid 54 2020-10-21 01:20:34.680 UTC [53] LOG: listening on IPv4 address "0.0.0.0", port 5432 2020-10-21 01:20:34.680 UTC [53] LOG: listening on IPv6 address "::", port 5432 2020-10-21 01:20:34.714 UTC [53] LOG: listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432" 2020-10-21 01:20:34.788 UTC [61] LOG: database system was shut down at 2020-10-21 01:20:33 UTC 2020-10-21 01:20:34.825 UTC [53] LOG: database system is ready to accept connections Postgresql service endpoint listening on https://:::3000 [GET] /healthcheck 2020-10-21 01:20:36,382 INFO success: postgresql entered RUNNING state, process has stayed up for > than 1 seconds (startsecs) 2020-10-21 01:20:36,382 INFO success: postgresql-service entered RUNNING state, process has stayed up for > than 1 seconds (startsecs) [GET] /healthcheck [GET] / [GET] / [GET] / [POST] /databases [POST] /databases [POST] /databases [DELETE] /databases/removetestdatabase -
So, could anyone here just try and run tests for addons on their machines, without any cloudron-related stuff, then just clone an addon and try to test it?
I've ran tests on my laptop, and on a server I have access to that doesn't run cloudron, and both of them time out in the same place.
DON'T RUN this tests on your production cloudron like I did, it will delete and recreate your postgresql (or whatever addon you're trying to use) and apps will go down heheh. I had to restore a couple of apps' backups, but it's all good now.
-
@malvim Maybe you can try to see if the mysql addon tests work in the meantime?
I ran the postgresl tests now and it did work for me:
> postgresql-addon@1.0.0 test /home/girish/yellowtent/postgresql-addon > mocha --bail ./test/test.js Postgresql Addon Error: No such container: postgresql Error response from daemon: network with name cloudron already exists auth ✓ fails without access_token ✓ fails with invalid access_token ✓ succeeds add database ✓ succeeds (401ms) ✓ succeeds when added again remove database ✓ succeeds (147ms) use the database ✓ can create extension (77ms) ✓ can create table foo ✓ can insert into table foo ✓ can read from table foo ✓ restart (5309ms) ✓ can read from table foo backup and restore ✓ succeeds to create backup (386ms) ✓ succeeds to create new database (743ms) ✓ succeeds to clear new database (439ms) ✓ succeeds to restore backup (1280ms) ✓ succeeds to check restore data (44ms) restore of invalid dump fails ✓ succeeds to create backup (178ms) ✓ succeeds to clear new database (426ms) ✓ fails to restore backup (180ms) restore of existing dump ✓ succeeds (1876ms) 21 passing (38s)
cause I'm missing what this unit test even is supposed to prove. That one module could run in a Cloudron environment?