Feat: Only allow authenticated users
-
Currently I don't intend to have any actionable logout, since the site which will be served up will be from the user and I don't want to inject some magic javascript there with a logout button I guess. So the session will eventually expire and I wanted to invalidate all sessions once the password changes.
-
hmm.. at least the auth with username & password does not yet seem to work properly. Even if I choose "user restricted" in the settings inside of Surfer I only get a single password prompt when opening the page in an incognito session.
I had also some problems with the new site title and favicon settings which were introduced in the version before (but I only got to play with now):
- setting an svg or maybe a too large icon does not properly store settings
- I originally wanted to set https://github.com/bastienwirtz/homer/blob/main/public/assets/icons/icon-any.svg, but after submitting the form and going back to it, it did not show my custom title and only showed a broken image instead of the favicon. Immediately after uploading it it did show.
- additionally settings towards the access also did not show in the form but seem to have been applied nonetheless
- the new login screen simply shows "undefined" instead of the set title. Using https://github.com/bastienwirtz/homer/blob/main/public/assets/icons/favicon-32x32.png id properly shown as the favicon
Edit: funny side effect of the new password auth. When you are in the admin panel and it loads a file as a preview it prompts you for the password in the preview pane.
- setting an svg or maybe a too large icon does not properly store settings
-
@fbartels ok look like I have to test this a bit more then. The preview pane issue is a good find!
The favicons are currently simply taken as is and depending on the browser they may or may not be scaled down or not rendered at all it looks like. I probably have to either add some checks upfront or scale it prior to storing on disk. -
The preview and also other related issues like thumbnails is fixed with latest package version.
I was not able to reproduce the missing username login field issue. Do you have any more information on this? Maybe in some cases we hit some caching issue or so?I also fixed an issue with the favicon in the settings dialog now. Still if too large images or unsupported formats are uploaded, they are just accepted and will thus result in missing favicons for now.
-
I am trying this out and have a few issues.
Enabling the public folder listing and setting access to user restricted, should not list the content until a user is logged in.
If I open the site in a new tab, it lists the files and shows a login button. Not expected.
If I open an incognito tab, it opens to a login page. As expected.
So the new tab should either give me a login page, or tell me I am logged in, if a browser session is being used to display the file listing.
-
@nebulon expectation is to not get a listing and a login prompt.
since I did, that means the session is being reused and I am logged in, yet the button shows as I am not logged in.
So maybe the fix here is to detect login state and adjust the button accordingly; perhaps a logout instead.