Environment variables NEXT_PUBLIC_WEBSITE_PRIVACY_POLICY_URL and NEXT_PUBLIC_WEBSITE_TERMS_URL for custom privacy policy and terms URLs ignored

[msbt]

@marylou not that exact fix, but in theory we could replace certain things as well, provided the image doesn't override them again

[nebulon]

since nextjs apps are designed to be built with the various domains known prior to building and then being deployed, this results in pretty much a hack already in our packaging code, where we replace magic strings in the build assets on app startup. Presumably we have to do the same for those then with the fallback mentioned at https://github.com/calcom/docker/pull/433/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R222

Will try to prepare a package change for those

[nebulon]

So the change is prepared and ready to go at https://git.cloudron.io/packages/calcom-app/-/merge_requests/172 however while the app works when changing those URLs I am actually not sure where those are even displayed. At least I wasn't able to find any. @marylou can you point me in the right direction so I can validate my change?

[msbt]

@nebulon if you click on an available day and select a timeslot, you get to the detail-view, where the links are at the bottom, next to the confirm button:

[nebulon]

ah wow, thanks I as on the lookout for some footer or so

[nebulon]

nice that worked. So next calcom release will include a way to customize those then.

[marylou]

Absolutely amazing! Thank you so so much, @nebulon!

[msbt]

thanks indeed @nebulon, good stuff!

[jkammerer]

it works. thank you.

[Neiluj]

Also from here - Thank you