Why do we have to push an image to a registry?
-
@Lonk said in Why do we have to push an image to a registry?:
Will the box patch be integrated into an update or will this remain a patch for developers (since we're likely the only ones who know how to patch box).
https://git.cloudron.io/cloudron/box/-/commit/546e38132510e29792323a9947ac7cdf9aa55c98
The patch is in a commit in the
master
branch, so it will be in the next release -
I moved the sysbox talk to the other topic, please keep the thread to a single topic. Otherwise, it's very hard to track discussions.
-
--no-push
stopped working for me (it still builds, but doesn't skip the push). I checked thebox
patch and it's there. I checked the CLI tool and it still has the option. The Build Service Bot got more updates, was there an issue with the Bot. Can you reproduce this @girish with the latest Cloudron Build Service app? -
I just checked and this is literally the only commit you made after
v1.2.1
that could have broken this, it could be related if you can reproduce this at least. I'll try to roll back my Build Service Version in the meantime.Oh, the commit that could have caused this: https://git.cloudron.io/cloudron/cloudron-build-service/-/commit/5012542ecd7d538a37fe8f84cfab096c588f0ac2
-
@girish I swear this
--no-push
feature worked perfectly for me until the Build Service got updated. Does it still work on your install (since we're both running onmaster
rn - maybe it still works on stable, with the small patch, and it's a separatemaster
issue - jus' wanna check)? -
I probably broke something with that latest commit you pointed out, I will check it.
-
Hopefully, this should be fixed now. Update the build service app.
-
@yusf said in Why do we have to push an image to a registry?:
Does this mean that we can also host the Cloudron build service on production machines, or am I mistaken?
Well, I run it only on a dev machine since I only use Cloudron to dev. But tbh, after 100s of builds. All of the other apps are still running smoothly so it's not recommended because it's the only app with the
docker
add-on and thus could technically mess with other apps. It has never done so, I just think they'd rather not have the responsibility of calling it "production-ready" even though in my dev environment, it gives me no issues. I would feel comfortable running this in production tbh. The worry is if it ever bugged. But I can actually work around that by accounting for it using a Cloudron add-on I'm building (Dot the Repair Bot) so even though it's never happened, if I account for the Build Service being able to destroy containers / data outside it's sandbox (what the devs mean when they say it's not for production), I can have them auto-restored by Dot.But if Dot got destroyed by the Build Service I'd be screwed.