LinkDing on Cloudron - Bookmarks Manage and Search
-
@Kubernetes I forked the app to https://git.cloudron.io/cloudron/linkding-app . You should have permissions.
I thought I will fix it but then thought I can help you along instead
-
First off, the app doesn't build. For example, it does
COPY linkding/package.json linkding/package-lock.json ./
. Where are these files in the repo? I am guessing you had linkding checked out locally when building the app maybe. Instead you should do something like https://git.cloudron.io/cloudron/changedetection-app/-/blob/master/Dockerfile#L9 . Also, see how the VERSION is pinned to a specific version of linkding. -
Next, in bootstrap.sh , you have
cp -nr /app/code/linkding/* /app/data/
. This is copying the code into data directory and now the code is also part of your backup. You should be able to run all the commands out of/app/code
itself (which is readonly filesystem). -
The apt is most likely redundant. The base image has all the libraries
-
There are actually two CMD . We can remove the HEALTHCHECK and the CMD immediately after, Cloudron does not use it.
-
You can rename bootstrap.sh to start.sh . This is just Cloudron convention
-
-
@girish I fixed the most mentioned things, but I still use to copy the application to /app/data because it needs to have write access when started.
EDIT 1: I did a merge request now
EDIT 2: I am not sure if I did push it right. I see the merged change in my repo now, but not in yours....
-
@girish No, it is not. I did a git clone of the forked repo to a new path. I tried it now twice, but both times the push (even with branch) is going to my repo, but not to yours. I am not experienced with using git in collaboration, so there might be something I am doing wrong. But I don't know what it is. When I try to push (without branching), I get this error:
user@homeserver:~/gitlab.cloudron-official/linkding-app$ git push Enumerating objects: 7, done. Counting objects: 100% (7/7), done. Delta compression using up to 4 threads Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 1.15 KiB | 1.15 MiB/s, done. Total 4 (delta 2), reused 0 (delta 0), pack-reused 0 remote: GitLab: You are not allowed to push code to protected branches on this project. To ssh://git.cloudron.io:6000/cloudron/linkding-app.git ! [remote rejected] main -> main (pre-receive hook declined) error: failed to push some refs to 'ssh://git.cloudron.io:6000/cloudron/linkding-app.git'
any hints?
-
@Kubernetes that looks like some permission issue . Let me check what I did..
-
@Kubernetes yes, was my mistake. Can you please try again?
-
-
I created a backup script that can be configured in the App Cron settings to backup the linkding database regulary to the /app/data/backups folder
#!/bin/bash mkdir -p /app/data/backups/ cd /app/data/backups/ CURRENT_TIMESTAMP=$(date +'%Y%m%d_%H%M%S') BACKUP_FILE="backup_${CURRENT_TIMESTAMP}.sqlite3" sqlite3 /app/data/data/db.sqlite3 ".backup '${BACKUP_FILE}'"
@girish
is it possible to get this configured automatically when deploying the package? -
@girish yes, I know that about regular updates. But in this case I am not sure, if a container data backup is the best way to backup a sqlite3 database. Not sure about open references and so. Thats why I thought a backup with sqlite backup command would be more resistant
-
-
-