Official App Store updates fail when a private registry hostname contains .docker

[andreasdueren]

Cloudron appears to match my private registry against Docker Hub because both hostnames contain .docker., selecting the private registry’s credentials for public image pulls.

For example, the failed Matomo update logged:

docker: pullImage: will pull registry.docker.com/cloudron/org.piwik.cloudronapp:202609212321130000. auth: yes

The pull failed, followed by a Quay fallback that returned manifest unknown. Existing apps continued running, but their updates remained in an error state.

Temporarily moving the registry to registry-docker.tld.com and updating its configured address, without changing credentials, changed the same Docker Hub pull to auth: no. All 20 pending official updates then succeeded.

The registry-matching code in src/docker.js appears to use .includes('.docker.') to recognize Docker Hub aliases. Could this be restricted to an explicit list of Docker Hub hostnames, while requiring exact hostname matching for private registries? Private-registry credentials should not be selected for unrelated registries.

[girish]

I guess we can check for .docker.com and .docker.io instead. Would that work @andreasdueren ?