Cloudron makes it easy to run web apps like WordPress, Nextcloud, GitLab on your server. Find out more or install now.


Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks
  • Search
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse
Brand Logo

Cloudron Forum

Apps | Demo | Docs | Install
  1. Cloudron Forum
  2. Surfer
  3. Feat: Only allow authenticated users

Feat: Only allow authenticated users

Scheduled Pinned Locked Moved Solved Surfer
26 Posts 5 Posters 4.0k Views 5 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • nebulonN Offline
    nebulonN Offline
    nebulon
    Staff
    wrote on last edited by
    #17

    The preview and also other related issues like thumbnails is fixed with latest package version.
    I was not able to reproduce the missing username login field issue. Do you have any more information on this? Maybe in some cases we hit some caching issue or so?

    I also fixed an issue with the favicon in the settings dialog now. Still if too large images or unsupported formats are uploaded, they are just accepted and will thus result in missing favicons for now.

    fbartelsF 1 Reply Last reply
    1
    • nebulonN nebulon

      The preview and also other related issues like thumbnails is fixed with latest package version.
      I was not able to reproduce the missing username login field issue. Do you have any more information on this? Maybe in some cases we hit some caching issue or so?

      I also fixed an issue with the favicon in the settings dialog now. Still if too large images or unsupported formats are uploaded, they are just accepted and will thus result in missing favicons for now.

      fbartelsF Offline
      fbartelsF Offline
      fbartels
      App Dev
      wrote on last edited by
      #18

      No, I don't think its a caching thing as I am always trying the login form in an incognito session. This is with v5.13.3:

      d44e7a10-0b97-47e6-944c-a8d0717a5287-image.png

      Settings:
      40fdafaf-fed0-44c1-a5a5-5c33d0fe1ac4-image.png

      Under access control in Cloudron I have set Allow all users from this Cloudron.

      nebulonN 1 Reply Last reply
      0
      • fbartelsF fbartels

        No, I don't think its a caching thing as I am always trying the login form in an incognito session. This is with v5.13.3:

        d44e7a10-0b97-47e6-944c-a8d0717a5287-image.png

        Settings:
        40fdafaf-fed0-44c1-a5a5-5c33d0fe1ac4-image.png

        Under access control in Cloudron I have set Allow all users from this Cloudron.

        nebulonN Offline
        nebulonN Offline
        nebulon
        Staff
        wrote on last edited by
        #19

        @fbartels oh! after looking at your instance itself I found the bug. You probably have the combination of access restriction and no public folder listing, in which case I missed to remove a token check. Will fix in a bit.

        fbartelsF 1 Reply Last reply
        0
        • nebulonN nebulon

          @fbartels oh! after looking at your instance itself I found the bug. You probably have the combination of access restriction and no public folder listing, in which case I missed to remove a token check. Will fix in a bit.

          fbartelsF Offline
          fbartelsF Offline
          fbartels
          App Dev
          wrote on last edited by
          #20

          @nebulon ah yes, that seems to be it. once I enabled public listing the login form did show the title and field for the username.

          Thanks

          nebulonN 1 Reply Last reply
          0
          • fbartelsF fbartels

            @nebulon ah yes, that seems to be it. once I enabled public listing the login form did show the title and field for the username.

            Thanks

            nebulonN Offline
            nebulonN Offline
            nebulon
            Staff
            wrote on last edited by
            #21

            @fbartels Ok this should be fixed with the latest package release now. Thanks for all the testing and reporting!

            fbartelsF 1 Reply Last reply
            1
            • nebulonN nebulon

              @fbartels Ok this should be fixed with the latest package release now. Thanks for all the testing and reporting!

              fbartelsF Offline
              fbartelsF Offline
              fbartels
              App Dev
              wrote on last edited by
              #22

              @nebulon said in Feat: Only allow authenticated users:

              Thanks for all the testing and reporting!

              I asked for the feature, it was the least I could do 😅

              1 Reply Last reply
              2
              • robiR Offline
                robiR Offline
                robi
                wrote on last edited by
                #23

                I am trying this out and have a few issues.

                Enabling the public folder listing and setting access to user restricted, should not list the content until a user is logged in.

                If I open the site in a new tab, it lists the files and shows a login button. Not expected.

                If I open an incognito tab, it opens to a login page. As expected.

                So the new tab should either give me a login page, or tell me I am logged in, if a browser session is being used to display the file listing.

                Conscious tech

                nebulonN 1 Reply Last reply
                0
                • robiR robi

                  I am trying this out and have a few issues.

                  Enabling the public folder listing and setting access to user restricted, should not list the content until a user is logged in.

                  If I open the site in a new tab, it lists the files and shows a login button. Not expected.

                  If I open an incognito tab, it opens to a login page. As expected.

                  So the new tab should either give me a login page, or tell me I am logged in, if a browser session is being used to display the file listing.

                  nebulonN Offline
                  nebulonN Offline
                  nebulon
                  Staff
                  wrote on last edited by
                  #24

                  @robi can you explain the "Not expected" case a bit further. Which and where do you see a login screen? (The login button in the public folder listing on the top right will always be there, if that is what you mean)

                  robiR 1 Reply Last reply
                  0
                  • nebulonN nebulon

                    @robi can you explain the "Not expected" case a bit further. Which and where do you see a login screen? (The login button in the public folder listing on the top right will always be there, if that is what you mean)

                    robiR Offline
                    robiR Offline
                    robi
                    wrote on last edited by
                    #25

                    @nebulon expectation is to not get a listing and a login prompt.

                    since I did, that means the session is being reused and I am logged in, yet the button shows as I am not logged in.

                    So maybe the fix here is to detect login state and adjust the button accordingly; perhaps a logout instead.

                    Conscious tech

                    1 Reply Last reply
                    0
                    • nebulonN Offline
                      nebulonN Offline
                      nebulon
                      Staff
                      wrote on last edited by
                      #26

                      Right, since you have the access token in this case in a new tab simply in the local storage, the session is refreshed and you see the files. I will fixup the login state/login button to show somethign like "Admin Dashboard" or so.

                      1 Reply Last reply
                      1
                      Reply
                      • Reply as topic
                      Log in to reply
                      • Oldest to Newest
                      • Newest to Oldest
                      • Most Votes


                      • Login

                      • Don't have an account? Register

                      • Login or register to search.
                      • First post
                        Last post
                      0
                      • Categories
                      • Recent
                      • Tags
                      • Popular
                      • Bookmarks
                      • Search