Cloudron makes it easy to run web apps like WordPress, Nextcloud, GitLab on your server. Find out more or install now.


    Cloudron Forum

    • Register
    • Login
    • Search
    • Categories
    • Recent
    • Tags
    • Popular

    Solved "Cleaning missing backups" = ??

    Support
    backups cleanup-backups
    4
    7
    190
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • timconsidine
      timconsidine last edited by girish

      Under the Backups tab, the button Cleanup Backups shows the message Cleaning missing backups during the operation.
      What does this mean ?
      What task is being performed ?
      If it's missing, how can it be cleaned ?
      Maybe slightly more explicit message needed.

      No big issues : just trying to understand why my Scaleway backups folder seems to grow and grow.
      Different message probably won't answer that, but it's a step on the way.

      nebulon 1 Reply Last reply Reply Quote 1
      • nebulon
        nebulon Staff @timconsidine last edited by

        @timconsidine what this message tries to say is, that the code checks for backups which are known in the database, but do not exist on the backup storage, then goes and cleans up the database.

        The code in question is at https://git.cloudron.io/cloudron/box/-/blob/master/src/backupcleaner.js#L202

        Do you have any suggestion on how to make this more obvious message wise?

        timconsidine 1 Reply Last reply Reply Quote 1
        • timconsidine
          timconsidine @nebulon last edited by

          @nebulon thank you
          I was guessing it might be like that ... so message is not bad, just not quite sure.
          Maybe 'Comparing backup database to storage' ?

          nebulon 1 Reply Last reply Reply Quote 0
          • nebulon
            nebulon Staff @timconsidine last edited by

            @timconsidine ok I've change the message now to Cleaning backup database https://git.cloudron.io/cloudron/box/-/commit/5c50534e21f782cfdc35304bd6783da586b80090

            timconsidine d19dotca 2 Replies Last reply Reply Quote 1
            • Topic has been marked as a question  nebulon nebulon 
            • Topic has been marked as solved  nebulon nebulon 
            • timconsidine
              timconsidine @nebulon last edited by

              @nebulon perfect, thank you

              1 Reply Last reply Reply Quote 0
              • d19dotca
                d19dotca @nebulon last edited by d19dotca

                @nebulon said in "Cleaning missing backups" = ??:

                @timconsidine ok I've change the message now to Cleaning backup database https://git.cloudron.io/cloudron/box/-/commit/5c50534e21f782cfdc35304bd6783da586b80090

                Honestly I feel like some people (particularly newer users) will be just as confused by that new message. “What is a backup database? And why does this function exist, what problem is it solving? And why are my backups in a database; aren’t they on the external disk / storage option I chose?” - I can picture people asking those questions. Lol. Personally I think it was totally fine how it was and perhaps just needed to be made more clear in the documentation the function of cleaning backups. Just my two cents anyways.

                --
                Dustin Dauncey
                www.d19.ca

                1 Reply Last reply Reply Quote 1
                • girish
                  girish Staff last edited by

                  The doc actually says "The Backup Cleaner checks if entries in the database exist in the storage backend and removes stale entries from the database automatically." I will fix the progress message to match this.

                  1 Reply Last reply Reply Quote 2
                  • First post
                    Last post
                  Powered by NodeBB