Cloudron makes it easy to run web apps like WordPress, Nextcloud, GitLab on your server. Find out more or install now.


  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks
Skins
  • Light
  • Cerulean
  • Cosmo
  • Flatly
  • Journal
  • Litera
  • Lumen
  • Lux
  • Materia
  • Minty
  • Morph
  • Pulse
  • Sandstone
  • Simplex
  • Sketchy
  • Spacelab
  • United
  • Yeti
  • Zephyr
  • Dark
  • Cyborg
  • Darkly
  • Quartz
  • Slate
  • Solar
  • Superhero
  • Vapor

  • Default (No Skin)
  • No Skin
Collapse

Cloudron Forum

Apps | Demo | Docs | Install

"Cleaning missing backups" = ??

Scheduled Pinned Locked Moved Solved Support
backupscleanup-backups
7 Posts 4 Posters 240 Views
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • timconsidineT Online
    timconsidineT Online
    timconsidine App Dev
    wrote on last edited by girish
    #1

    Under the Backups tab, the button Cleanup Backups shows the message Cleaning missing backups during the operation.
    What does this mean ?
    What task is being performed ?
    If it's missing, how can it be cleaned ?
    Maybe slightly more explicit message needed.

    No big issues : just trying to understand why my Scaleway backups folder seems to grow and grow.
    Different message probably won't answer that, but it's a step on the way.

    nebulonN 1 Reply Last reply
    1
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    replied to timconsidine on last edited by
    #2

    @timconsidine what this message tries to say is, that the code checks for backups which are known in the database, but do not exist on the backup storage, then goes and cleans up the database.

    The code in question is at https://git.cloudron.io/cloudron/box/-/blob/master/src/backupcleaner.js#L202

    Do you have any suggestion on how to make this more obvious message wise?

    timconsidineT 1 Reply Last reply
    1
  • timconsidineT Online
    timconsidineT Online
    timconsidine App Dev
    replied to nebulon on last edited by
    #3

    @nebulon thank you
    I was guessing it might be like that ... so message is not bad, just not quite sure.
    Maybe 'Comparing backup database to storage' ?

    nebulonN 1 Reply Last reply
    0
  • nebulonN Offline
    nebulonN Offline
    nebulon Staff
    replied to timconsidine on last edited by
    #4

    @timconsidine ok I've change the message now to Cleaning backup database https://git.cloudron.io/cloudron/box/-/commit/5c50534e21f782cfdc35304bd6783da586b80090

    timconsidineT d19dotcaD 2 Replies Last reply
    1
  • nebulonN nebulon marked this topic as a question on
  • nebulonN nebulon has marked this topic as solved on
  • timconsidineT Online
    timconsidineT Online
    timconsidine App Dev
    replied to nebulon on last edited by
    #5

    @nebulon perfect, thank you

    1 Reply Last reply
    0
  • d19dotcaD Offline
    d19dotcaD Offline
    d19dotca
    replied to nebulon on last edited by d19dotca
    #6

    @nebulon said in "Cleaning missing backups" = ??:

    @timconsidine ok I've change the message now to Cleaning backup database https://git.cloudron.io/cloudron/box/-/commit/5c50534e21f782cfdc35304bd6783da586b80090

    Honestly I feel like some people (particularly newer users) will be just as confused by that new message. “What is a backup database? And why does this function exist, what problem is it solving? And why are my backups in a database; aren’t they on the external disk / storage option I chose?” - I can picture people asking those questions. Lol. Personally I think it was totally fine how it was and perhaps just needed to be made more clear in the documentation the function of cleaning backups. Just my two cents anyways.

    --
    Dustin Dauncey
    www.d19.ca

    1 Reply Last reply
    1
  • girishG Do not disturb
    girishG Do not disturb
    girish Staff
    wrote on last edited by
    #7

    The doc actually says "The Backup Cleaner checks if entries in the database exist in the storage backend and removes stale entries from the database automatically." I will fix the progress message to match this.

    1 Reply Last reply
    2

  • Login

  • Don't have an account? Register

  • Login or register to search.
  • First post
    Last post
0
  • Categories
  • Recent
  • Tags
  • Popular
  • Bookmarks
  • Login

  • Don't have an account? Register

  • Login or register to search.