"Cleaning missing backups" = ??

[timconsidine]

Under the Backups tab, the button Cleanup Backups shows the message Cleaning missing backups during the operation.
What does this mean ?
What task is being performed ?
If it's missing, how can it be cleaned ?
Maybe slightly more explicit message needed.

No big issues : just trying to understand why my Scaleway backups folder seems to grow and grow.
Different message probably won't answer that, but it's a step on the way.

[nebulon]

@timconsidine what this message tries to say is, that the code checks for backups which are known in the database, but do not exist on the backup storage, then goes and cleans up the database.

The code in question is at https://git.cloudron.io/cloudron/box/-/blob/master/src/backupcleaner.js#L202

Do you have any suggestion on how to make this more obvious message wise?

[timconsidine]

@nebulon thank you
I was guessing it might be like that ... so message is not bad, just not quite sure.
Maybe 'Comparing backup database to storage' ?

[nebulon]

@timconsidine ok I've change the message now to Cleaning backup database https://git.cloudron.io/cloudron/box/-/commit/5c50534e21f782cfdc35304bd6783da586b80090

[timconsidine]

@nebulon perfect, thank you

[d19dotca]

@nebulon said in "Cleaning missing backups" = ??:

@timconsidine ok I've change the message now to Cleaning backup database https://git.cloudron.io/cloudron/box/-/commit/5c50534e21f782cfdc35304bd6783da586b80090

Honestly I feel like some people (particularly newer users) will be just as confused by that new message. “What is a backup database? And why does this function exist, what problem is it solving? And why are my backups in a database; aren’t they on the external disk / storage option I chose?” - I can picture people asking those questions. Lol. Personally I think it was totally fine how it was and perhaps just needed to be made more clear in the documentation the function of cleaning backups. Just my two cents anyways.

[girish]

The doc actually says "The Backup Cleaner checks if entries in the database exist in the storage backend and removes stale entries from the database automatically." I will fix the progress message to match this.