HumHub - social network software

[atridad]

@girish Actually, I just thought of something. If the modules folder is symlinked and the app is expecting to write to the modules folder in /app/code, it will error right? I imagine it wouldn't just look at the actual folder in /app/data. The trouble here is there is a "module store" of sorts built right into the app.

[girish]

@atrilahiji maybe you can symlink /app/code/modules to /app/data/modules and that way it will become writable.

To give a high level idea, let's say humhub app comes with some default modules. Then, in Dockerfile, you would move them to some other location like:

RUN mv /app/code/modules /app/code/modules_orig && ln -s /app/data/modules /app/code/modules

Then in start.sh:

mkdir -p /app/code/modules
cp -r /app/code/modules_orig/* /app/data/modules

In many apps, instead of the blind copy above, we try to symlink each "module". So, there will be a symlink from /app/data/modules/x to /app/code/modules_orig/x . This sometimes works or not depending on the app. But hopefully you get the idea!

[atridad]

@girish my confusion here is if the app still tries to write to /app/code/modules it would hit permissions issues no?

[atridad]

@girish Running into issues here: https://docs.humhub.org/docs/admin/installation/#file-permissions

There appears to be no way to configure where Hubhub looks for those files, so it will just keep trying to write to the symlink in /app/code and fail. In fact, you cant even get the site to load after installation without having the assets directory writable. This is something it has to do on startup. I can still make an update script for this, but I think it will have to sit in /app/data just based on how this was written. Unless I'm missing something?

[fbartels]

@atrilahiji said in HumHub - social network software:

if the app still tries to write to /app/code/modules it would hit permissions issues no?

no, that should not be the case (at least when the symlinked dir has proper permissions for this).

[atridad]

@fbartels Weird... it seemed to think it didn't have permission to write...

[atridad]

[scooke]

@atrilahiji Never stop never stopping! You're doing great!

[fbartels]

@atrilahiji can you push your current wip? I'd like to give the code a look.

[atridad]

@fbartels Sure thing: https://git.atridad.dev/alt-ron/cloudron-humhub-app/-/tree/harden-app-code

Thanks! I'm convinced this is 1) impossible or 2) something so simple yet I have not noticed it somehow

[fbartels]

@atrilahiji for me this works with

➜  cloudron-humhub-app git:(harden-app-code) git rev-parse --short HEAD
0b5df1c

Steps I tried:

• Install app (in debug mode, but only so that i could override and start the start.sh manually)
• finished Humhub installation
• went into admin and selected modules
• installed a module
• activated a module
• no php error can be seen

[atridad]

@fbartels Huh so you manually started start.sh from the terminal in recovery mode? I get the exact same error doing that. Did you do something else to modify the permissions?

[fbartels]

@atrilahiji no, no changes at all. maybe some leftovers from a previous installation of yours?

Yes, you can run cloudron install --debug where then the init script is not run. you then need to exec into the app and run it manually.

[atridad]

@fbartels ahhh I see what you mean. I'll try that.

[atridad]

@fbartels Oh weird yeah that works... no clue why it wouldn't work if the start.sh is run normally during an install...

IDK if you saw the same error but if I don't start in debug mode and switch to Recovery Mode, running start.sh results in a permission error for PHP again.

EDIT: Nvm I think I figured it out...

[fbartels]

@atrilahiji ah nevermind, i forgot that part of debug is that the container is not read-only. Looking at the code now a bit closer.

[fbartels]

@atrilahiji the modules directory does not exist at all in /app/code and then it fails at creating it in the first place. You have to prepare this in a similar way to https://git.atridad.dev/alt-ron/cloudron-humhub-app/-/blob/harden-app-code/Dockerfile#L78-80 where the folder symlink needs to already be created during docker build and then in start.sh you need to make sure that the folder and its default contents exist.

[atridad]

@fbartels I think I got it working finally. I'll test it one more time and then push the code up.

[atridad]

This should work now: https://git.atridad.dev/alt-ron/cloudron-humhub-app/-/releases/0.8.0

Now to tackle updates. With everything we need in /app/data now it should be a piece of cake. Thanks for the help @fbartels !

[fbartels]

@atrilahiji yes, now it also starts in normal (non debug) mode. A nice addition would be auto configuration of ldap.

[atridad]

@fbartels I thought I had that set up, but I might have broken it. I'll look into it.

[atridad]

@fbartels AH so it does, but on restart. The reason being is it does not let me configure LDAP until the app is installed in the ui on first boot.

Testing both new installs and updates right now for a 1.0.0 release.

[atridad]

Had a few dumb bugs, and here we are at 1.0.3. But hey it works. Now I know never to work on windows. The line endings being wrong fucked the package.

[Sam_uk]

@atridad I'm getting a cert error on your repo.

[girish]

@sam_uk I think https://git.atridad.dev/CTPR/cloudron-humhub-app is the new location

[atridad]

@sam_uk Whoops yeah, I had not mentioned in an email that I moved things to a new org on my gitlab. Mostly because I didn't like how Altron just sounded like the marvel villain

[atridad]

I've also been getting in the habit of storing my containers I built over on my gitlab registry. So that project should now have an image built for 1.1.0 of the package.

[Sam_uk]

@girish Great thanks. What are the next steps for getting this in the app store, please?

[atridad]

@sam_uk @girish Just pushed a new release that fixes a huge issue. The DB credentials never got updated when you clone from backup, so you'd end up with 2 instances connected to the same DB.

1.1.1 is pushed now.

Repo: https://git.atridad.dev/CTPR/cloudron-humhub-app
Container: docker.atridad.dev:443/ctpr/cloudron-humhub-app:1.1.1

[jdaviescoates]

@atridad @girish I'm looking forward to having this in the app store... I'm guessing that might happen sometime soon?

[toja]

Wonderfully promising - thanks a kazillion @atridad

Really looking forward to this. Any news on when this might land in the app store @girish?

[atridad]

@toja I'll throw my vote in here for that as well. The fewer production apps that depend on my docker instance the better