Support for Azure blobs storage & Azure DNS
-
Forgot to mention, you have to sign our CLA as well since we preserve the author's history and ownership in the commit log - https://cla.cloudron.io/
-
@girish It's a different API from S3 to be sure, but isn't complex. Great work @mfcodeworks - that'd be huge for backups. Currently, I've got Minio running in Azure App Services where all my backups point.
On the DNS side, I simple use a wildcard setup in Azure DNS, so no API interface needed, but if @mfcodeworks can create one for Azure DNS that can work against the API, that too would expand the options for DNS hosting.
One additional note - for "live" storage, I'm currently testing NFS on Azure Storage preview to see if the IO performs well enough to make it the primary store, instead of really expensive 'disks.' Looking really good so far!
-
@mehdi said in Support for Azure blobs storage & Azure DNS:
@mario i believe the full text of the CLA is at the link girish gave : https://cla.cloudron.io/
You're right, sorry - was super early.
-
Hey guys, @girish I've signed the CLA, if I can get permission to fork I can push my code for review
-
Thanks @nebulon, I've opened a merge request with the code for review
-
Hey guys, has anyone had a chance to check out the MR yet
-
Ok, so it needs rebasing and merging due to package.json changes in current master. I did that locally unfortunately in your case you didn't seem to create a branch for the MR, so to update this now I would have to force push to your master branch in your box repo fork, which is protected (by default).
So I think the best might be if we close that merge request, then you would create a new branch and push that and then create a new merge request, which I can then update (unless of course you already rebased this)
-
@mfcodeworks also, which parts of the code were already tested against azure? Just to get an overview. You are probably already aware that we also have to add some bits to the dashboard code, but I can do that quickly once we know the backend code works.
-
@nebulon thanks for the response, I'll setup a new branch for a new MR and do some more thorough testing (Beyond the basic preliminary test) early next week to confirm all the code is working as expected
-
@mfcodeworks You also have to patch this bit of code - https://git.cloudron.io/cloudron/box/-/blob/master/src/backups.js#L94 so that your provider gets picked up.
-
Hey guys, sorry for the delay
I've updated the fork and the providers function, if I get permission to create a new branch or you open one I can open an MR with the new branch and let you review