Support for Azure blobs storage & Azure DNS

[mehdi]

@mario i believe the full text of the CLA is at the link girish gave : https://cla.cloudron.io/

[mario]

@mehdi said in Support for Azure blobs storage & Azure DNS:

@mario i believe the full text of the CLA is at the link girish gave : https://cla.cloudron.io/

You're right, sorry - was super early.

[mfcodeworks]

Hey guys, @girish I've signed the CLA, if I can get permission to fork I can push my code for review

[nebulon]

@mfcodeworks thanks! You should be able to fork now.

[mfcodeworks]

Thanks @nebulon, I've opened a merge request with the code for review

[mfcodeworks]

Hey guys, has anyone had a chance to check out the MR yet

[nebulon]

Sorry that it took so long. I am looking at it now. Just trying to rebase that thing due to changes in master. I also have to setup some azure storage for testing first.

[nebulon]

Ok, so it needs rebasing and merging due to package.json changes in current master. I did that locally unfortunately in your case you didn't seem to create a branch for the MR, so to update this now I would have to force push to your master branch in your box repo fork, which is protected (by default).

So I think the best might be if we close that merge request, then you would create a new branch and push that and then create a new merge request, which I can then update (unless of course you already rebased this)

[nebulon]

@mfcodeworks also, which parts of the code were already tested against azure? Just to get an overview. You are probably already aware that we also have to add some bits to the dashboard code, but I can do that quickly once we know the backend code works.

[mfcodeworks]

@nebulon thanks for the response, I'll setup a new branch for a new MR and do some more thorough testing (Beyond the basic preliminary test) early next week to confirm all the code is working as expected

[girish]

@mfcodeworks You also have to patch this bit of code - https://git.cloudron.io/cloudron/box/-/blob/master/src/backups.js#L94 so that your provider gets picked up.

[robi]

fronting Azure via Minio is also an option.

[mfcodeworks]

Hey guys, sorry for the delay

I've updated the fork and the providers function, if I get permission to create a new branch or you open one I can open an MR with the new branch and let you review