Invoice ninja server 500 internal error

[humptydumpty]

@girish email delivery doesn't work for me unless I keep PDF_GENERATOR=hosted_ninja in the env file. PDF generation works fine with or without that line now. Should I report this upstream as a new/separate issue?

[AartJansen]

oh crap neither does mine!
I've sent quite a few reminders today, and new invoices, I take it they are just failing silently and not queued anywhere?

[luckow]

You are right. There is something wrong with sending emails. I tried to send offers to my own e-mail address and checked https://my.example.org/#/emails-eventlog.
The emails are going out, but to a completely different email address.
Investigating (Invoice Ninja 5.10.2)

[luckow]

ok. a few hours later.

• Fresh install of invoice ninja seems to work.
• my updated instance sends email exclusively to the mail address from user 1.
• dashboard Recent Activity shows the problem

sending mails works
Stephan Luckow emailed invoice RG-240481 for ACME inc. to Jane Doe

sending mails does not work anymore
Stephan Luckow emailed quote 0023-0052 for ACME inc. to

to is empty. Maybe there is a default setting in the code, if no "to" is set, it will be sent to the administrator account (or user 1).

I have restored old versions of IN from backups.
Up to v1.13.5, sending mails works. In v1.13.6 I have a problem with logging into my account. Next I will test v1.13.7.

Side quest: In the latest version (in my updated instance) it is impossible to change the mail address of user 1 via the user interface.

[luckow]

In my case, the problem starts with the emails in v1.13.7. Maybe in v1.13.6, but I can't log in in that version.
Next: updating from v1.13.5

[luckow]

@luckow ok. reproducible builds / updates. v1.13.5 -> v1.13.6 (no log-in possible) -> v1.13.7 (mails do not work)
next: migrate broken app into a new installation.

[luckow]

The moment I restore the settings (broken updated instance -> fresh instance), the new instance shows the same behavior. Data is not a problem.

[luckow]

restoring from a working v1.13.5 export -> fresh v1.14.2 produces same behaviour. the moment i restore settings, bam.
comparing json files is not one of my daily tasks, so I decide to do that:

• install a fresh IN
• import data only
• manually click configuration options.

Fun fact: It is possible to set a password that starts with a space for the login. ONLY for login. After you have logged in and your action requires a password confirmation, the leading space will be removed, and your password is incorrect.

[nebulon]

@luckow maybe good to report this password trimming upstream. Great catch and unlikely it gets detected by the devs on their own.

[humptydumpty]

That leaves the email deliverability issue. How is PDF generation related to emails not getting sent?

[luckow]

@nebulon I will try three more times to be sure the leading space is the problem. After hours of trillions of IN instances and attempts, my eyes feel square.

[vladimir.d]

@luckow could you try to switch Attach PDF option off on IN dashboard > settings > Advanced Settings > Email Settings and then try to send an email?

v1.14.2 seems to be sending emails properly whilst Attach PDF is off.
I'm investigating it further now.

[humptydumpty]

@vladimir-d I can confirm that the emails get delivered if attach pdf is off. I deleted PDF_GENERATOR=hosted_ninja from the env file and restarted the app before testing. I'm on the lastest IN 1.14.2.

[vladimir.d]

The problem with sending emails has been fixed. A new app package is going to be released soon.

[luckow]

@nebulon fixed https://github.com/invoiceninja/invoiceninja/pull/9703

[humptydumpty]

Well done @luckow @vladimir-d

[girish]

Thanks! New package published.

[AartJansen]

so the end result is pdf generation & emails (with PDFs) now work without the added PDF_GENERATOR line ?

[humptydumpty]

@AartJansen correct!

[d19dotca]

Interestingly I just ran across this issue. I was able to fix it by simply adding in the following: PDF_GENERATOR=snappdf

Odd though as I see others didn't get that working and needed a value of hosted_ninja instead of snappdf. So YMMV as they say.