SOLVED Are you ok NodeBB?

[atridad]

[girish]

@atrilahiji The forum just updated to nodebb 1.15. Did it break the dark theme?

[atridad]

@girish And the Favicon

[girish]

Favicon looks OK here.

[atridad]

@girish Oh maybe I just remember it being the cloudron logo. Guess thats the update process. Never run NodeBB

[girish]

@atrilahiji Yes, I just realized that. It was the Cloudron logo It doesn't seem to work indeed.

[girish]

Tried restarting the forum and it seems the favicon is back!

[girish]

Guess we have to report the dark mode bug upstream. Let me collect all the bugs with the latest version and report it together.

[jdaviescoates]

Infinite scrolling of threads seems to have gone too and been replaced by pagination. I got really confused for a moment wondering where the rest of a thread and gone.

[Lonkle]

@girish said in Are you ok NodeBB?:

Guess we have to report the dark mode bug upstream. Let me collect all the bugs with the latest version and report it together.

I’ve likewise been reporting bugs and enhancements upstream to NodeBB since I joined this forum. They’re pretty good about it!

[Lonkle]

@jdaviescoates said in Are you ok NodeBB?:

Infinite scrolling of threads seems to have gone too and been replaced by pagination. I got really confused for a moment wondering where the rest of a thread and gone.

I think that’s a user preference, isn’t it?

[jdaviescoates]

@lonk said in Are you ok NodeBB?:

I think that’s a user preference, isn’t it?

Indeed it is:

But I think the recent update must've changed the default or something, because I had never manually checked that box.

[jdaviescoates]

I'm guessing that the length of time it's possible to edit posts has also changed with the update, but now it seems there are lots of posts I can no longer edit (but can still edit newer ones).

[girish]

I was playing around with some setting yesterday and I think I turned on pagination by default. I have put it back to what it was. It's a per user setting anyway.

[marcusquinn]

Dammit, was hoping they'd include the cmd-Enter shortcut for Submit?

[girish]

It seems https://community.nodebb.org also updated to the latest version. That one doesn't seem to have the dark mode bug.

[Lonkle]

@marcusquinn said in Are you ok NodeBB?:

Dammit, was hoping they'd include the cmd-Enter shortcut for Submit?

Make a GitHub issue for that. It’s a good idea! Their team is v responsive.

[marcusquinn]

@Lonk already did, they already fixed, just not sure when it will be included in a release.

[yusf]

Nor only dark mode i broken but a more serious issue is that the reading space has been reduced by roughly 40%. This is horrible

[girish]

@yusf @atrilahiji I opened https://github.com/NodeBB/nodebb-theme-persona/issues/510 for the light out mode.

[girish]

Actually, go to your settings and select the skin as Darkly. Don't use the light bulb button on the top. It seems maybe this is a plugin issue (isn't it always?).

[Lonkle]

@girish said in Are you ok NodeBB?:

Actually, go to your settings and select the skin as Darkly. Don't use the light bulb button on the top. It seems maybe this is a plugin issue (isn't it always?).

This works to an extent; it messes with the textarea input field colors, and the unread color which makes notifications unreadable (some weird orange color):

I may just go back to default and use "dark mode" the lightbulb way.

[girish]

@lonk If I turn off the light bulb and just choose Darkly, it works ok here.

[Lonkle]

@girish said in Are you ok NodeBB?:

@lonk If I turn off the light bulb and just choose Darkly, it works ok here.

That worked. The notifications are still improperly outlined in orange, but the text is green in this theme so it's easier to see even if it's not the most ideal constrast. It's better than my screenshot.

[girish]

It's fixed now it seems - https://github.com/psychobunny/nodebb-plugin-night-mode/commit/d90027d0424a9f3e44ad3e57c81615f2ae48f09f

[girish]

I have updated the theme.

[yusf]

@girish My main issue is this one:

the reading space has been reduced by roughly 40%.

… on mobile devices, because of the sticky header.

[BrutalBirdie]

Fun fact, this is the first time this NodeBB has a fav icon at all
For me the fav icon is the Cloudron logo.

[jdaviescoates]

@brutalbirdie I've had that the whole time I've used this forum, i.e. since January.

[girish]

@yusf said in Are you ok NodeBB?:

… on mobile devices, because of the sticky header.

Can you can take this up upstream? They are usually quite responsive in their community forum - https://community.nodebb.org . I think your point about the mobile screen space being drastically reduced is quite valid. You can see same behavior in their forum as well on mobile.

[marcusquinn]

@lonk cmd-Enter for Mac is fixed now, must have been cached files from before the update that have now cleared.

[Lonkle]

@girish said in Are you ok NodeBB?:

@yusf said in Are you ok NodeBB?:

… on mobile devices, because of the sticky header.

Can you can take this up upstream? They are usually quite responsive in their community forum - https://community.nodebb.org . I think your point about the mobile screen space being drastically reduced is quite valid. You can see same behavior in their forum as well on mobile.

Yeah, I threw some feature requests in their Github (like increasing the size of the upvote button on mobile so you can actually hit it) and I think they already committed code to fix it. So I'm sure they'd do the same for your suggestion, since it's a good user preference to have.

[julian]

Looks like this is fixed (and also the header bar in the category view, as well)